Add Http discovery transport to denied list for JMX#1918
Merged
cshannon merged 3 commits intoapache:mainfrom Apr 14, 2026
Merged
Add Http discovery transport to denied list for JMX#1918cshannon merged 3 commits intoapache:mainfrom
cshannon merged 3 commits intoapache:mainfrom
Conversation
cshannon
changed the title
This also prevents the Http discovery transport from being added as a connector or network connector through JMX and Jolokia
cshannon
force-pushed
the
broker-mbean-transport-filter
branch
from
621e2d7 to
69edccd
Compare
cshannon
changed the title
jbonofre
previously approved these changes
Apr 14, 2026
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(BrokerView.class); | ||
|
|
||
| private static final Set<String> DENIED_TRANSPORT_SCHEMES = Set.of("vm", "http"); |
Member
There was a problem hiding this comment.
Should we consider https here?
Contributor
Author
There was a problem hiding this comment.
Surprisingly (or maybe not given the age) there is no https discovery protocol, the broker only supports http for that.
There is http and https transports but those are not the same as the http discovery.
Here is the location for the http/https transport references: https://github.com/apache/activemq/tree/main/activemq-http/src/main/resources/META-INF/services/org/apache/activemq/transport
And here is the location for http discovery: https://github.com/apache/activemq/tree/main/activemq-http/src/main/resources/META-INF/services/org/apache/activemq/transport/discoveryagent
Contributor
Author
There was a problem hiding this comment.
A future enhancement could be to add https if people are using it
jbonofre
approved these changes
Apr 14, 2026
github-project-automation
bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.3.0
cshannon
added a commit
to cshannon/activemq
that referenced
this pull request
Apr 14, 2026
This also prevents the Http discovery transport from being added as a connector or network connector through JMX and Jolokia (cherry picked from commit 5bda7d8)
cshannon
added a commit
to cshannon/activemq
that referenced
this pull request
Apr 14, 2026
This also prevents the Http discovery transport from being added as a connector or network connector through JMX and Jolokia (cherry picked from commit 5bda7d8)
cshannon
added a commit
that referenced
this pull request
Apr 14, 2026
cshannon
added a commit
that referenced
this pull request
Apr 14, 2026
pburgess147
pushed a commit
to peersoftware/activemq
that referenced
this pull request
Apr 17, 2026
…ache#1925) This also prevents the Http discovery transport from being added as a connector or network connector through JMX and Jolokia (cherry picked from commit 5bda7d8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also prevents the Http discovery transport from being added as a connector or network connector through JMX and Jolokia