fix(errors): store cli_path as attribute on CLINotFoundError#989
Open
SHAI-Akshay-Tripathi wants to merge 2 commits into
Open
fix(errors): store cli_path as attribute on CLINotFoundError#989SHAI-Akshay-Tripathi wants to merge 2 commits into
SHAI-Akshay-Tripathi wants to merge 2 commits into
Conversation
Added tests for CLINotFoundError with and without path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CLINotFoundErrorpreviously acceptedcli_pathas a constructor argumentbut only used it to format the error message — the path itself was not
retained as an attribute. This PR stores it as
self.cli_path.Why
The other custom error classes in
src/claude_agent_sdk/_errors.pyallexpose their structured arguments as attributes:
ProcessError→self.exit_code,self.stderrCLIJSONDecodeError→self.line,self.original_errorMessageParseError→self.dataCLINotFoundErrorwas the lone exception, which meant callers wanting toreact to the missing-path case (e.g. log it, attempt a fallback location,
emit a metric) had to string-parse the message.
Example of what becomes possible:
python except CLINotFoundError as e: if e.cli_path: log.warning("Claude CLI missing at %s", e.cli_path) The message-formatting behaviour is unchanged, so this is fully
backward-compatible.
How to test
bash python -m pytest tests/test_errors.py -v The existing
test_cli_not_found_erroris extended with one assertion,and a new
test_cli_not_found_error_with_pathcovers the path-providedcase, mirroring the style of
test_process_error.