Skip to content
This repository was archived by the owner on Nov 21, 2017. It is now read-only.

Rules for formtastic forms inside of modal windows added#8

Open
dermarkus wants to merge 1 commit into
antage:masterfrom
digineo:master
Open

Rules for formtastic forms inside of modal windows added#8
dermarkus wants to merge 1 commit into
antage:masterfrom
digineo:master

Conversation

@dermarkus

Copy link
Copy Markdown
Contributor

I think this might be useful.

@ghost ghost assigned antage Oct 1, 2012
@antage

antage commented Oct 2, 2012

Copy link
Copy Markdown
Owner

I like the idea but I dislike some implementation details.

formtastic-responsive() is hardcoded for .modal. What if I want to use modal window 1024px width and a full-width form inside?

I propose let a programmer to choose between a narrow form and a full-width form. You could add a new class .formtastic-verical (as I proposed in #4) that explicitly changes form appearance.

I think the following styles are too strict. I (or someone) may use non-default size modal window and I want control input fields size.

// the height of textareas should be limited
textarea {
  height: 200px !important;
}

fieldset.inputs ol > li.input .input-xxlarge {
  width: 100% !important;
}

I propose to add a new class .input-fullwidth (width: 100%). Textarea height can be changed manually by custom css rules. No reason it should be hardcoded to 200px.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants