refactor(multiple): Clean up afterRenderEffect usage across angular aria#33054
Open
adolgachev wants to merge 8 commits intoangular:mainfrom
Open
refactor(multiple): Clean up afterRenderEffect usage across angular aria#33054adolgachev wants to merge 8 commits intoangular:mainfrom
adolgachev wants to merge 8 commits intoangular:mainfrom
Conversation
983eefc to
e9fc811
Compare
e9fc811 to
8b8a855
Compare
|
Deployed dev-app for b420025 to: https://ng-dev-previews-comp--pr-angular-components-33054-dev-v6daybga.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
…s and use computed for patterns
…effect appropriately
… for validation messages
8d0dc28 to
b420025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Across angular-aria afterRenderEffect was being used as a general-purpose synching hook. Also, a phase was not specified so it always was defaulting to the mixedReadWrite phase which is not as performant and unnecessary in all the cases.
This PR cleans up the usage by:
See https://angular.dev/guide/signals/effect#render-phases for background.