fix: treat removed/recycled entities as non-existent and fix Count()#29
Merged
Conversation
Removed entities kept their stale record, so Has/Get on a removed id returned stale data. RemoveEntity now tombstones the slot (key = -1) and a new public Exists() guards every Has/Get/Add/Remove path; a dead entity is reported as non-existent and double-remove is a safe no-op. The non-generic RemoveComponent and GetComponent (and the generic GetComponent) gain the bounds guard they were missing. CreateWorld now allocates entities with capacity but zero length, so Count() returns 0 for a fresh world instead of the preallocated capacity.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed entities kept their stale record, so Has/Get on a removed id returned stale data.
RemoveEntity now tombstones the slot (key = -1) and a new public Exists() guards every Has/Get/Add/Remove path; a dead entity is reported as non-existent and double-remove is a safe no-op.
The non-generic RemoveComponent and GetComponent (and the generic GetComponent) gain the bounds guard they were missing.
CreateWorld now allocates entities with capacity but zero length, so Count() returns 0 for a fresh world instead of the preallocated capacity.