fix: prevent RemoveEntity panic when removing entities carrying tags#28
Merged
Conversation
RemoveEntity looked up world.storage[componentId] for every component of the entity's archetype. Tag ids are >= TAGS_INDICES, which is the length of the storage slice, so removing any tagged entity indexed out of range and panicked. Skip tag ids (they have no backing storage), mirroring moveComponentsToArchetype.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveEntity looked up world.storage[componentId] for every component of the
entity's archetype.
Tag ids are >= TAGS_INDICES, which is the length of the
storage slice, so removing any tagged entity indexed out of range and panicked.
Skip tag ids (they have no backing storage), mirroring moveComponentsToArchetype.