chore(ci): update secret env references to variable env references#75
Open
mk0x9 wants to merge 1 commit into
Open
chore(ci): update secret env references to variable env references#75mk0x9 wants to merge 1 commit into
mk0x9 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow configuration to treat certain values as non-secret variables rather than secrets, and removes an inline “not a secret” value from the secrets map used for the Ketryx reporting reusable workflow.
Changes:
- Switch
E2E_TEST_ENVIRONMENTandE2E_ADMIN_USER_EMAILfromsecrets.*tovars.*in CI E2E test env. - Remove
KETRYX_PROJECTfrom the caller workflow’ssecrets:mapping and update the reusable Ketryx workflow to no longer accept it as a secret. - Update the reusable Ketryx workflow to source the project ID from configuration rather than
secrets.KETRYX_PROJECT.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ci-cd.yml | Uses GitHub Variables (vars.*) for non-secret E2E configuration and stops passing KETRYX_PROJECT as a secret. |
| .github/workflows/_report-to-ketryx.yml | Removes KETRYX_PROJECT from workflow_call.secrets and changes how the Ketryx project ID is provided to the action. |
Comment on lines
6
to
10
| build-name: | ||
| description: 'The build name to report' | ||
| required: true | ||
| type: string | ||
| secrets: |
| uses: Ketryx/ketryx-github-action@v1.4.0 | ||
| with: | ||
| project: ${{ secrets.KETRYX_PROJECT }} | ||
| project: ${{ vars.KETRYX_PROJECT }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.