fix(core): reuse classpath skill jar file systems#1981
Open
guslegend0510 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1979.
ClasspathSkillRepositoryfailed in jar deployments when the same classpath skill location was initialized more than once in the same JVM. The second repository instance could throwFileSystemAlreadyExistsExceptionbecause the jarFileSystemwas always created withFileSystems.newFileSystem(...).This change makes jar-backed classpath repositories reuse the same mounted
FileSystemand only close it when the last repository referencing it is released.Root Cause
In jar environments,
ClasspathSkillRepositorycreated a new ZipFS for every instance, even when the target jar URI had already been mounted. That caused:FileSystemAlreadyExistsExceptionon repeated initializationChanges
FileSysteminstances by URIFileSystemwhen the last repository releases itTests
Ran:
mvn -pl agentscope-core -Dtest=ClasspathSkillRepositoryTest testAdded coverage for:
repeated ClasspathSkillRepository creation against the same normal jar
repeated ClasspathSkillRepository creation against the same Spring Boot nested jar
repository close ordering, ensuring one repository closing does not break another still using the same shared jar FileSystem