fix(model): propagate executionConfig in OllamaOptions fromOptions/toBuilder#1958
Open
eye-gu wants to merge 1 commit into
Open
fix(model): propagate executionConfig in OllamaOptions fromOptions/toBuilder#1958eye-gu wants to merge 1 commit into
eye-gu wants to merge 1 commit into
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
itxaiohanglover
approved these changes
Jun 30, 2026
itxaiohanglover
left a comment
itxaiohanglover
left a comment
Contributor
There was a problem hiding this comment.
Clean fix. Both fromOptions and toBuilder now correctly propagate executionConfig, matching the pattern used for all other fields. The 3-line diff is minimal and directly addresses the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.12, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
fix: #1957
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)