Skip to content

feat(schema): Stabilize addl dirs and remove unstable model selectors #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbrandt merged 1 commit into from
Jun 2, 2026
+208 −596
Merged

feat(schema): Stabilize addl dirs and remove unstable model selectors #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions schema/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
"session_prompt": "session/prompt",
"session_resume": "session/resume",
"session_set_config_option": "session/set_config_option",
"session_set_mode": "session/set_mode",
"session_set_model": "session/set_model"
"session_set_mode": "session/set_mode"
},
"clientMethods": {
"elicitation_complete": "elicitation/complete",
Expand Down
461 changes: 206 additions & 255 deletions schema/schema.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion scripts/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as fs from "fs/promises";
import { dirname } from "path";
import * as prettier from "prettier";

const CURRENT_SCHEMA_RELEASE = "v0.13.4";
const CURRENT_SCHEMA_RELEASE = "v0.13.5";

await main();

Expand Down
39 changes: 0 additions & 39 deletions src/acp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,6 @@ export class AgentSideConnection {
const validatedParams = validate.zPromptRequest.parse(params);
return agent.prompt(validatedParams);
}
case schema.AGENT_METHODS.session_set_model: {
if (!agent.unstable_setSessionModel) {
throw RequestError.methodNotFound(method);
}
const validatedParams =
validate.zSetSessionModelRequest.parse(params);
const result = await agent.unstable_setSessionModel(validatedParams);
return result ?? {};
}
case schema.AGENT_METHODS.session_set_config_option: {
if (!agent.setSessionConfigOption) {
throw RequestError.methodNotFound(method);
Expand Down Expand Up @@ -916,24 +907,6 @@ export class ClientSideConnection implements Agent {
>(schema.AGENT_METHODS.session_set_mode, params, emptyObjectResponse);
}

/**
* **UNSTABLE**
*
* This capability is not part of the spec yet, and may be removed or changed at any point.
*
* Select a model for a given session.
*
* @experimental
*/
unstable_setSessionModel(
params: schema.SetSessionModelRequest,
): Promise<schema.SetSessionModelResponse> {
return this.connection.sendRequest<
schema.SetSessionModelRequest,
schema.SetSessionModelResponse
>(schema.AGENT_METHODS.session_set_model, params, emptyObjectResponse);
}

/**
* Set a configuration option for a given session.
*
Expand Down Expand Up @@ -2081,18 +2054,6 @@ export interface Agent {
setSessionMode?(
params: schema.SetSessionModeRequest,
): Promise<schema.SetSessionModeResponse | void>;
/**
* **UNSTABLE**
*
* This capability is not part of the spec yet, and may be removed or changed at any point.
*
* Select a model for a given session.
*
* @experimental
*/
unstable_setSessionModel?(
params: schema.SetSessionModelRequest,
): Promise<schema.SetSessionModelResponse | void>;
/**
* Set a configuration option for a given session.
*
Expand Down
6 changes: 0 additions & 6 deletions src/schema/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ export type {
MessageMcpNotification,
MessageMcpRequest,
MessageMcpResponse,
ModelId,
ModelInfo,
MultiSelectItems,
MultiSelectPropertySchema,
NesCapabilities,
Expand Down Expand Up @@ -216,7 +214,6 @@ export type {
SessionListCapabilities,
SessionMode,
SessionModeId,
SessionModelState,
SessionModeState,
SessionNotification,
SessionResumeCapabilities,
Expand All @@ -225,8 +222,6 @@ export type {
SetProviderResponse,
SetSessionConfigOptionRequest,
SetSessionConfigOptionResponse,
SetSessionModelRequest,
SetSessionModelResponse,
SetSessionModeRequest,
SetSessionModeResponse,
StartNesRequest,
Expand Down Expand Up @@ -292,7 +287,6 @@ export const AGENT_METHODS = {
session_resume: "session/resume",
session_set_config_option: "session/set_config_option",
session_set_mode: "session/set_mode",
session_set_model: "session/set_model",
} as const;

export const CLIENT_METHODS = {
Expand Down
Loading