Skip to content

chore(cli): route update notice to stderr#190

Merged
vreshch merged 1 commit into
masterfrom
chore/stderr-update-notice
May 20, 2026
Merged

chore(cli): route update notice to stderr#190
vreshch merged 1 commit into
masterfrom
chore/stderr-update-notice

Conversation

@vreshch
Copy link
Copy Markdown
Member

@vreshch vreshch commented May 20, 2026

Summary

  • cli.ts printed the "Update available" notice via console.log (stdout), TTY-guarded
  • The surrounding comment already calls out stdout-pollution as a problem for `--json` consumers
  • Routes to console.error (stderr) so stdout stays clean regardless of TTY state

Test plan

  • CI green
  • agentage status --json | jq still produces clean stdout when an update is available

The update notice was written to stdout (TTY-guarded). Stdout pollution
is a known concern in this file — the surrounding comment already calls
out that non-TTY stdout corrupts --json consumers. Routing to stderr
keeps stdout pure regardless of TTY state.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

🎉 PR Validation ✅ PASSED

Commit: fef40bc614ead3630cea39c479a342cdbd307158
Branch: chore/stderr-update-notice

Checks:

  • ✅ Release guard (no version/changelog changes)
  • ✅ Dependencies installed
  • ✅ Type check passed
  • ✅ Linting passed
  • ✅ Format check passed
  • ✅ Tests + coverage passed
  • ✅ Build successful

Ready to merge!


🔗 View workflow run
⏰ Generated at: 2026-05-20T19:53:17.098Z

@vreshch vreshch force-pushed the chore/stderr-update-notice branch 2 times, most recently from 2fc1bd7 to fef40bc Compare May 20, 2026 19:52
@vreshch vreshch marked this pull request as ready for review May 20, 2026 19:52
@vreshch vreshch merged commit a10cb65 into master May 20, 2026
1 check passed
@vreshch vreshch deleted the chore/stderr-update-notice branch May 20, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant