Skip to content

fix: wrong depName for gotemplate + spurious empty registryUrl warning#286

Merged
amuraru merged 1 commit into
masterfrom
fix/renovate-gotemplate-depname-and-registryurl-warning
Jul 14, 2026
Merged

fix: wrong depName for gotemplate + spurious empty registryUrl warning#286
amuraru merged 1 commit into
masterfrom
fix/renovate-gotemplate-depname-and-registryurl-warning

Conversation

@amuraru

@amuraru amuraru commented Jul 14, 2026

Copy link
Copy Markdown

Summary

Follow-up to #285. Both bugs fixed here only surfaced after #285 merged and Renovate re-evaluated master — visible in the Mend job log (https://developer.mend.io/github/adobe/koperator) and reflected in PR #279 / the Dependency Dashboard (#156):

WARN: Package lookup failures (branch="renovate/master-all-minor-patch")
{ "warnings": ["Failed to look up github-releases package cznic/gotemplate: no-result"], "files": ["Makefile"] }

WARN: Invalid regex manager registryUrl
{ "baseBranch": "master", "value": "" }

Changes

  1. Wrong depName: Makefile's GOTEMPLATE_VERSION annotation said depName=cznic/gotemplate, but the Makefile actually does go install github.com/coveooss/gotemplate/v3@v$(GOTEMPLATE_VERSION) a few lines down. cznic/gotemplate doesn't exist on GitHub (confirmed 404), so the lookup could never succeed — likely a copy-paste slip from whoever originally annotated it. Fixed to depName=coveooss/gotemplate, which exists and has a v3.12.0 release matching the currently pinned version.

  2. Spurious empty-string registryUrl warning: fix: unblock two more dependencies silently dropped by Renovate customManagers #285's fix for ZookeeperOperatorVersion (datasource=docker) made registryUrl optional in the regex, but registryUrlTemplate still rendered to "" for it, since docker deps have no Helm-repo registryUrl. A templated empty string is still a defined (invalid) registryUrl to Renovate, not the same as omitting it — hence the warning. Split the customManager into two: the original, unchanged, for Helm entries that always carry a registryUrl, plus a new one scoped to the literal datasource=docker (RE2 has no lookaround, so this is how the split avoids overlap without negative-lookahead tricks) that never defines registryUrlTemplate at all. Renovate then auto-derives the registry from the image name itself.

Test plan

Per feedback on the previous PR, verified with a real renovate run instead of just the config validator:

  • renovate-config-validator passes
  • renovate --platform=local --dry-run=full (LOG_LEVEL=debug) run end-to-end against this branch, with real datasource lookups. Confirmed in the output:
    • coveooss/gotemplate resolves cleanly, warnings: []
    • ghcr.io/adobe/helm-charts/zookeeper-operator extracted with registryUrl auto-derived as https://ghcr.io, warnings: []
    • apache/kafka (from fix: make Renovate actually track the Kafka docker image version #284) still tracked, updates: [] — 3.9.2 is in fact the latest 3.x release, nothing newer within the allowedVersions "<4.0.0" pin (confirmed against GitHub tags directly)
    • zero occurrences of "invalid regex", "lookup fail", or "no-result" anywhere in the full run log

🤖 Generated with Claude Code

Both bugs surfaced live after #285 merged and Renovate re-evaluated
master (per the Mend job log the user pulled from
https://developer.mend.io/github/adobe/koperator, and PR #279 /
Dependency Dashboard #156):

  WARN: Package lookup failures (branch="renovate/master-all-minor-patch")
  { "warnings": ["Failed to look up github-releases package
  cznic/gotemplate: no-result"], "files": ["Makefile"] }

  WARN: Invalid regex manager registryUrl { "value": "" }

1. Makefile's GOTEMPLATE_VERSION annotation said `depName=cznic/gotemplate`,
   but the Makefile actually `go install`s `github.com/coveooss/gotemplate/v3`
   (see the bin/gotemplate target a few lines down) - `cznic/gotemplate`
   doesn't exist on GitHub at all (confirmed 404), so the datasource
   lookup could never succeed. Fixed the depName to `coveooss/gotemplate`,
   which does exist and has a v3.12.0 release matching the pinned version.

2. My #285 fix made tests/e2e/versions.go's ZookeeperOperatorVersion
   (datasource=docker) match by making registryUrl optional in the
   regex, but registryUrlTemplate still rendered to an empty string for
   it (docker deps have no Helm-repo registryUrl) - and a templated ""
   is still a defined-but-invalid registryUrl to Renovate, not the same
   as omitting it, hence the warning. Split this into two customManagers
   instead: the original one, unchanged, for helm entries that always
   carry a registryUrl, plus a new one - scoped to the literal
   `datasource=docker` (RE2 has no lookaround, so this is how the split
   avoids overlap without negative-lookahead trickery) - that never
   defines registryUrlTemplate at all. Renovate then auto-derives the
   registry from the image name (confirmed via local run: it correctly
   resolved to https://ghcr.io on its own).

Verified for real, not just via renovate-config-validator: ran
`renovate --platform=local --dry-run=full` end-to-end (LOG_LEVEL=debug)
against this branch. Confirmed in the output:
  - coveooss/gotemplate resolves cleanly, warnings: []
  - ghcr.io/adobe/helm-charts/zookeeper-operator now extracted with
    registryUrl auto-derived as https://ghcr.io, warnings: []
  - apache/kafka still tracked from #284, updates: [] (3.9.2 is in fact
    the latest 3.x release - nothing newer within the allowedVersions
    "<4.0.0" pin, confirmed against GitHub tags)
  - zero occurrences of "invalid regex", "lookup fail", or "no-result"
    anywhere in the full run log

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@amuraru amuraru merged commit 8313552 into master Jul 14, 2026
6 checks passed
@amuraru amuraru deleted the fix/renovate-gotemplate-depname-and-registryurl-warning branch July 14, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant