Skip to content

Chore: Revert last changes in wai-deploy action#2418

Merged
daniel-montalvo merged 1 commit into
developfrom
update-wai-deploy-action
Jun 9, 2026
Merged

Chore: Revert last changes in wai-deploy action#2418
daniel-montalvo merged 1 commit into
developfrom
update-wai-deploy-action

Conversation

@daniel-montalvo

Copy link
Copy Markdown
Collaborator

<< Describe the changes >>

Closes issue(s):

  • closes #XXX (ADD ISSUE NUMBER HERE)

Need for Call for Review:
<< choose one of the following and remove the rest >>
<< check Process Document on Call for Review >>
This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >>
This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >>
This will require a 1 week Call for Review << small changes affecting a small number of examples, if in doubt do not use this. >>
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this. >>


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
    As per previous discussion I am reverting this.

@daniel-montalvo daniel-montalvo self-assigned this Jun 8, 2026
@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 2ce8e5a
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a26d4c3ff9980000887847e
😎 Deploy Preview https://deploy-preview-2418--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo daniel-montalvo changed the title Reverts last changes in wai-deploy action Revert last changes in wai-deploy action Jun 8, 2026
@daniel-montalvo daniel-montalvo changed the title Revert last changes in wai-deploy action Chore: Revert last changes in wai-deploy action Jun 9, 2026
@daniel-montalvo daniel-montalvo merged commit 0706a53 into develop Jun 9, 2026
6 checks passed
@daniel-montalvo daniel-montalvo deleted the update-wai-deploy-action branch June 9, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants