security: fix SSRF in multimodal image URL loading (_load_image)#2220
Open
hoangperry wants to merge 1 commit into
Open
security: fix SSRF in multimodal image URL loading (_load_image)#2220hoangperry wants to merge 1 commit into
hoangperry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_image()callsurllib.request.urlopen(image_url)with no URL validation. When deployed as a server-side inference API, any user who sends chat completion requests withimage_urlcontent can cause the server to make HTTP requests to internal network addresses.Vulnerable code (before)
urllib.request.urlopenfollows HTTP redirects by default, so an attacker-controlled server returning a 302 to an internal address bypasses any future IP filtering.Attack scenario
{"role": "user", "content": [{"type": "image_url", "image_url": {"url": "http://internal-service/"}}]}The server fetches the internal URL.
Fix
_validate_image_url(): resolves hostname to IP and blocks RFC 1918, loopback, and link-local ranges (169.254.x.x cloud metadata endpoints)._ValidatingRedirectHandler: validates every redirect target before following, preventing redirect-chain bypass.Test plan
http://127.0.0.1/blocked (loopback)http://169.254.169.254/blocked (cloud metadata)http://10.0.0.1/blocked (RFC 1918)https://public-site.com/image.jpgstill works