fix: Fixes for Jakarta#874
Open
kabir wants to merge 1 commit into
Open
Conversation
Collaborator
kabir
commented
May 12, 2026
kabir
commented
- Don't use TCCL to initialise the Http Client
- Default to protocol version 1.0 when no gRPC interceptor has set the version. The WildFly gRPC subsystem does not currently have an A2A header interceptor.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates A2AHttpClientFactory to use a specific class loader for service discovery, avoiding the Thread Context Class Loader, and modifies GrpcHandler to default to the current protocol version when none is provided in the context. Feedback suggests ensuring consistency by updating other ServiceLoader calls in the factory and recommends using the ServiceLoader.stream() API for better readability.
- Don't use TCCL to initialise the Http Client - Default 1.0 gRPC version to 1.0 if not found by interceptor (haven't worked out how to register this in WildFly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.