Skip to content

Add unit tests for exception handling#151

Draft
Beeram12 wants to merge 2 commits into
XortexAI:mainfrom
Beeram12:feature/unit-tests
Draft

Add unit tests for exception handling#151
Beeram12 wants to merge 2 commits into
XortexAI:mainfrom
Beeram12:feature/unit-tests

Conversation

@Beeram12
Copy link
Copy Markdown

@Beeram12 Beeram12 commented May 5, 2026

fixes #147

  1. This adds unit tests for exception.py .

@github-actions github-actions Bot added the tests label May 5, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request unignores the tests/ directory and introduces a new test suite for the project's custom exception hierarchy. The feedback focuses on improving test accuracy by fixing a typo and directly verifying attributes, adhering to PEP 8 standards for None comparisons, and ensuring complete coverage of the exception hierarchy by adding a test for VectorStoreValidationError.

Comment thread tests/test_exception.py Outdated
Comment thread tests/test_exception.py Outdated
Comment thread tests/test_exception.py
@ishaanxgupta
Copy link
Copy Markdown
Member

@Beeram12 Please have a look on the gemini suggestions

@Beeram12
Copy link
Copy Markdown
Author

Beeram12 commented May 8, 2026

@Beeram12 Please have a look on the gemini suggestions

yeah I have resovled all but I didnt commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 1: Foundation and Core Unit Tests

2 participants