feat: add sample trimming functionality and update UI components#2
Merged
Conversation
- Introduced `setPadTrim` method in `SampleEngine` to manage sample start and end points. - Updated `Screen` and `Waveform` components to synchronize knob values with sample trim settings. - Enhanced `Waveform` component to support zooming and trimming via mouse interactions. - Modified `Knob` labels for clarity and improved user guidance in `StartOverlay`. - Added CSS styles for trim handles to visually represent sample trimming in the waveform view. - Updated README to include a disclaimer
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setPadTrimmethod inSampleEngineto manage sample start and end points.ScreenandWaveformcomponents to synchronize knob values with sample trim settings.Waveformcomponent to support zooming and trimming via mouse interactions.Knoblabels for clarity and improved user guidance inStartOverlay.