Skip to content

Options: Return false from get_transient() when transient timeout is missing #12523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SainathPoojary wants to merge 3 commits into
base: trunk
Choose a base branch
from
+22 −1
Open

Options: Return false from get_transient() when transient timeout is missing #12523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f64986
Options: Return false from get_transient() when transient timeout is …
SainathPoojary Jul 14, 2026
17c166f
Tests/Options: Add tests for get_transient() and get_site_transient()
SainathPoojary Jul 14, 2026
a692d5c
Options: Revert site transient changes
SainathPoojary Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wp-includes/option.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,7 +1464,9 @@ function get_transient( $transient ) {
$transient_timeout = '_transient_timeout_' . $transient;
wp_prime_option_caches( array( $transient_option, $transient_timeout ) );
$timeout = get_option( $transient_timeout );
if ( false !== $timeout && $timeout < time() ) {
if ( false === $timeout ) {
$value = false;
} elseif ( $timeout < time() ) {
delete_option( $transient_option );
delete_option( $transient_timeout );
$value = false;
Expand Down
19 changes: 19 additions & 0 deletions tests/phpunit/tests/option/transient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,4 +265,23 @@ public function test_nonexistent_key_old_timeout() {
);
$this->assertSame( $expected, $a->get_events() );
}

/**
* Ensure get_transient() returns false when the transient timeout option is missing (broken transient).
*
* @ticket 33561
*
* @covers ::get_transient
*/
public function test_get_transient_returns_false_when_timeout_is_missing() {
$key = 'test_transient_broken';
$value = 'test_value';

set_transient( $key, $value, 60 * 10 );
$this->assertSame( $value, get_transient( $key ) );

delete_option( '_transient_timeout_' . $key );

$this->assertFalse( get_transient( $key ) );
}
}
Loading