Button: Migrate to width block support

[aaronrobertshaw]

Backport of Gutenberg PR WordPress/gutenberg#74242

Trac ticket: https://core.trac.wordpress.org/ticket/65388

This migrates the Button block to the dimensions.width block support.

This PR backports:

• the global-styles calc() conversion for percentage button widths in WP_Theme_JSON,
• the core/button dimension-size presets in theme.json,
• and the accompanying WP_Theme_JSON tests.

Dependency: Requires #10869 (Theme JSON: Define preset CSS vars for blocks based on feature selectors) to be committed first.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[ramonjd]

I know it's a draft, but I checked update_button_width_declarations and get_styles_for_block against the changes in WordPress/gutenberg#74242 👍🏻

What is the bot doing deleting the theme.json changes? f6e2ddd 🤔

[aaronrobertshaw]

What is the bot doing deleting the theme.json changes? f6e2ddd 🤔

No idea, to be honest. I'll have to look into it.

[adrianduffell]

@aaronrobertshaw is this ready for review?

[tellthemachines]

Looks like there's a couple more places using update_button_width_declarations in the corresponding gutenberg class:

• within foreach ( array_keys( $responsive_media_queries ) as $breakpoint ) loop in get_styles_for_block
• in the process_pseudo_selectors function.

would be worth adding those in here too. Other than that, LGTM!

[aaronrobertshaw]

Thanks for the nudge, I've been caught up on other things and left this on the backburner too long 😬

would be worth adding those in here too. Other than that, LGTM

Yep, part of things moving on with states and responsive styles after this was spun up. I'll cross check everything, update this accordingly, and flag of review.

[ramonjd]

@aaronrobertshaw this one is still a draft. what's missing? are you able to take care of it?

[aaronrobertshaw]

I've crossed checked Gutenberg's call sites for updating the button block's width declarations after the recent state and responsive styling updates.

The count and locations match between Gutenberg and Core now and this faithfully brings across the changes from the original PR. So, I think this is good for a review, approval, and merge now.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, isabel_brison, ramonopoly, adrianduffell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[ramonjd]

Thanks for taking care of that. I'll give it a run today. Cheers!

[tellthemachines]

Changes LGTM!

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62746
GitHub commit: 25d2739

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.