Skip to content

Small timeout fixes #5

Open
dbulos5 wants to merge 23 commits into
masterfrom
TIMEOUT_FIXES
Open

Small timeout fixes #5
dbulos5 wants to merge 23 commits into
masterfrom
TIMEOUT_FIXES

Conversation

@dbulos5
Copy link
Copy Markdown
Collaborator

@dbulos5 dbulos5 commented May 26, 2026

corrected timeout_length function, added description to differentiate between module and inverter timeout, added 'inCar' to Inverter timeout arg to remove redundant faults

@dbulos5 dbulos5 requested a review from yamaan93 May 26, 2026 13:04
Copy link
Copy Markdown
Member

@yamaan93 yamaan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine the main issue is we need to update our DBC and maybe even modify the packStatus message to give us the module and timeout length in CAN, I'd also rename getMaxCanTimeout() to getMaxInverterTimeout() to avoid confusion

@dbulos5
Copy link
Copy Markdown
Collaborator Author

dbulos5 commented May 26, 2026

I made the function name change. I didn't want to touch pack status since it's nearly full, and i'm assuming you already have an idea to handle the CAN.

@dbulos5
Copy link
Copy Markdown
Collaborator Author

dbulos5 commented May 27, 2026

@yamaan93 I've now verified on charge cart and in car

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants