Skip to content

feat: made BlockRelative non final#5

Closed
noone-075 wants to merge 3 commits into
WebMCDevelopment:mainfrom
noone-075:patch-1
Closed

feat: made BlockRelative non final#5
noone-075 wants to merge 3 commits into
WebMCDevelopment:mainfrom
noone-075:patch-1

Conversation

@noone-075

Copy link
Copy Markdown
Contributor

i just want to be able to extand it 😭

changed fields from private to protected
made #place not final
@colbster937

Copy link
Copy Markdown
Member

why

@noone-075

Copy link
Copy Markdown
Contributor Author

so i can overwrite place function to be able to make custom block relative

@colbster937

Copy link
Copy Markdown
Member

i just cant see any use cases, can you explain exactly what you're thinking of doing?

@noone-075

noone-075 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

i want to be able to expand the BlockRelative so i can create [censored]BlockRelative class for my dblk idea, it would allow me to overwrite #place to apply pdc and i want to do this so i can use .add on the structure with it after loading the schematic.

@colbster937

Copy link
Copy Markdown
Member

all that blockrelative stores is the block material and the relative coordinates to the placement location. that isnt enough information to use a pdc on.

@noone-075

Copy link
Copy Markdown
Contributor Author

well thats exactly why i want to extend the class, to store more information...

@colbster937

Copy link
Copy Markdown
Member

a pdc isnt practical as there isnt any real block being stored here, plus why would you extend it instead of just implementing it directly into BlockRelative?

@noone-075

Copy link
Copy Markdown
Contributor Author

let me send you my idea into discord (dev chat of dblk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants