Feat/vbi component/add chart editor#519
Open
trannhatminhdev wants to merge 163 commits into
Open
Conversation
self-close editor tags
…n proportional scroll
Collaborator
|
@LoganLCX Please review this PR, vbi-components has been rewritten. |
youngwinds
reviewed
Jul 13, 2026
Collaborator
There was a problem hiding this comment.
I don’t think this is necessary. Cconsumers of the component will set the root styles themselves.
Collaborator
There was a problem hiding this comment.
.
Many users need to query thousands of records. So VBI_MAX_LIMIT is not necessary.
Collaborator
There was a problem hiding this comment.
you can directly observe the measures, rather than the whole builder
Collaborator
There was a problem hiding this comment.
you can use the id.uuid()
youngwinds
reviewed
Jul 13, 2026
Collaborator
There was a problem hiding this comment.
we use oxfmt, so we must remove prettier
…sed code - Remove globalStyle (src/global/app.css) from stencil.config.ts - Add scoped box-sizing reset (src/common/styles/reset.css) and import into component styles - Remove unused randomUUID utility, VBI_MAX_LIMIT constant, and redundant .prettierrc.json
trannhatminhdev
force-pushed
the
feat/vbi-component/add-chart-editor
branch
from
67c162a to
cd9385e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added vbi-chart-editor for vbi-component