Support Rails render_in options signature#2636
Open
joelhawksley wants to merge 12 commits into
Open
Conversation
Rails merged rails/rails#50623, which changes the `render_in` signature from `render_in(view_context, &block)` to `render_in(view_context, **options, &block)`. This enables objects implementing `render_in` to receive render-time options like locals. All tests pass. The changes maintain backward compatibility since `**options` is an optional parameter.
- Update Ruby 4.0 allocation expectations to use ranges to account for increased allocations from render_in(**options) changes in Rails main - Update ActiveModel error test to accept either ViewComponent error or ActiveModel::UnknownAttributeError as Rails main now validates attributes earlier
…ibility Appraisal converts hyphens to underscores in gemfile names, so rails-main-head in Appraisals generates rails_main_head.gemfile
- Update Appraisals file: rails-main-head -> rails-main_head - Update CI matrix: main-head -> main_head - This ensures BUNDLE_GEMFILE path matches actual gemfile name (appraisal always converts to underscores in filenames)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails merged rails/rails#50623, which changes the
render_insignature fromrender_in(view_context, &block)torender_in(view_context, **options, &block).The changes here maintain backward compatibility since
**optionsis an optional parameter.