Skip to content

docs: update cluster exposing and update strategy docs#2308

Merged
vrutkovs merged 1 commit into
masterfrom
update-strategy-and-exposing
Jun 22, 2026
Merged

docs: update cluster exposing and update strategy docs#2308
vrutkovs merged 1 commit into
masterfrom
update-strategy-and-exposing

Conversation

@AndrewChubatiuk

Copy link
Copy Markdown
Contributor

fixes #1506
fixes #1699

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/resources/vmcluster.md">

<violation number="1" location="docs/resources/vmcluster.md:408">
P2: Comment says `Recreate` is "for minimum downtime" — this is backwards. `Recreate` kills all pods before creating new ones, causing full downtime. `RollingUpdate` (the default) provides zero-downtime updates by incrementally replacing pods.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

spec:
vminsert:
replicaCount: 3
updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime

@cubic-dev-ai cubic-dev-ai Bot Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Comment says Recreate is "for minimum downtime" — this is backwards. Recreate kills all pods before creating new ones, causing full downtime. RollingUpdate (the default) provides zero-downtime updates by incrementally replacing pods.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/resources/vmcluster.md, line 408:

<comment>Comment says `Recreate` is "for minimum downtime" — this is backwards. `Recreate` kills all pods before creating new ones, causing full downtime. `RollingUpdate` (the default) provides zero-downtime updates by incrementally replacing pods.</comment>

<file context>
@@ -264,6 +332,85 @@ spec:
+spec:
+  vminsert:
+    replicaCount: 3
+    updateStrategy: RollingUpdate   # default; set to Recreate for minimum downtime
+    rollingUpdate:
+      maxUnavailable: 1
</file context>
Suggested change
updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime
updateStrategy: RollingUpdate # default; set to Recreate for faster restart at the cost of downtime
Fix with cubic

spec:
vminsert:
replicaCount: 3
updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime
updateStrategy: RollingUpdate # default; set to Recreate for short update time at the cost of a short downtime

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimum downtime strategy is used in vmcluster docs, probably wording can be updated and converted to the link to respective cluster section

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay, lets change it all together then

@vrutkovs vrutkovs enabled auto-merge (squash) June 22, 2026 09:31
@vrutkovs vrutkovs force-pushed the update-strategy-and-exposing branch from 07f2458 to 6bc8fe3 Compare June 22, 2026 09:31
@vrutkovs vrutkovs merged commit d2239c4 into master Jun 22, 2026
8 checks passed
@vrutkovs vrutkovs deleted the update-strategy-and-exposing branch June 22, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants