docs: update cluster exposing and update strategy docs#2308
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/resources/vmcluster.md">
<violation number="1" location="docs/resources/vmcluster.md:408">
P2: Comment says `Recreate` is "for minimum downtime" — this is backwards. `Recreate` kills all pods before creating new ones, causing full downtime. `RollingUpdate` (the default) provides zero-downtime updates by incrementally replacing pods.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| spec: | ||
| vminsert: | ||
| replicaCount: 3 | ||
| updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime |
Contributor
There was a problem hiding this comment.
P2: Comment says Recreate is "for minimum downtime" — this is backwards. Recreate kills all pods before creating new ones, causing full downtime. RollingUpdate (the default) provides zero-downtime updates by incrementally replacing pods.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/resources/vmcluster.md, line 408:
<comment>Comment says `Recreate` is "for minimum downtime" — this is backwards. `Recreate` kills all pods before creating new ones, causing full downtime. `RollingUpdate` (the default) provides zero-downtime updates by incrementally replacing pods.</comment>
<file context>
@@ -264,6 +332,85 @@ spec:
+spec:
+ vminsert:
+ replicaCount: 3
+ updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime
+ rollingUpdate:
+ maxUnavailable: 1
</file context>
Suggested change
| updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime | |
| updateStrategy: RollingUpdate # default; set to Recreate for faster restart at the cost of downtime |
vrutkovs
requested changes
Jun 22, 2026
| spec: | ||
| vminsert: | ||
| replicaCount: 3 | ||
| updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime |
Collaborator
There was a problem hiding this comment.
Suggested change
| updateStrategy: RollingUpdate # default; set to Recreate for minimum downtime | |
| updateStrategy: RollingUpdate # default; set to Recreate for short update time at the cost of a short downtime |
Contributor
Author
There was a problem hiding this comment.
minimum downtime strategy is used in vmcluster docs, probably wording can be updated and converted to the link to respective cluster section
Collaborator
There was a problem hiding this comment.
Oh, okay, lets change it all together then
vrutkovs
approved these changes
Jun 22, 2026
07f2458 to
6bc8fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1506
fixes #1699