Add UndoEdaStudy step to remove EDA metadata before undoing a single rnaSeq dataset#89
Open
jbrestel wants to merge 1 commit into
Open
Add UndoEdaStudy step to remove EDA metadata before undoing a single rnaSeq dataset#89jbrestel wants to merge 1 commit into
jbrestel wants to merge 1 commit into
Conversation
…g a single rnaSeq dataset When undoing a single study, EDA metadata rows left by sampleDetailsForEda block the loadDataset undo. This adds a per-dataset step to rnaSeqExperiment and ebiRnaSeqExperiment templates that runs undoEdaStudy.pl on undo, ensuring EDA metadata is removed before the dataset record is deleted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UndoEdaStudy.pmWorkflowStep: no-op forward (writes a log file), runsundoEdaStudy.pl --extDbRlsSpec ... --gusConfigFile ...on undo and removes the log file${name}_rnaSeq_undoEdaStudystep to thernaSeqExperimentdatasetTemplate inrnaseq.xml, depending on${name}_analyze_rnaSeq_experiment${name}_ebi_rnaSeq_undoEdaStudystep to theebiRnaSeqExperimentdatasetTemplate inrnaseq.xml, depending on${name}_ebi_rnaSeq_experimentProblem
When undoing a single RNAseq study, EDA metadata rows loaded by sampleDetailsForEda (via StudyDealerNextflow) are left in place by design. This blocks the loadDataset undo because FK constraints still reference the dataset record. This step ensures those rows are cleaned up for the specific study before loadDataset is undone.
Test plan
🤖 Generated with Claude Code