test(eval): cover --simulation flag on uipath debug#1633
Open
ajay-kesavan wants to merge 1 commit into
Open
Conversation
Adds TestDebugSimulationFlag mirroring TestRunSimulation: - Invalid --simulation JSON surfaces a clean error and does not start the runtime stack - A valid --simulation payload is parsed into SimulationConfig and routed through build_mocking_context; the simulation.json disk loader is bypassed - Without --simulation, cli_debug still delegates to load_simulation_config so existing on-disk simulation.json behavior is preserved Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked onto #1632. Adds
TestDebugSimulationFlagmirroring theTestRunSimulationclass introduced foruipath run --simulationin #1624.Three cases:
--simulationJSON surfaces a clean error and never starts the runtime stack--simulationpayload is parsed intoSimulationConfigand routed throughbuild_mocking_context; the on-disksimulation.jsonloader is bypassed--simulation,cli_debugstill delegates toload_simulation_config— existing disk-file behavior is preservedWhy stacked
Direct pushes to
feat/debug-simulation-flagare blocked by the repo's "Copilot" ruleset (pull_requestrule on~ALLbranches). Merging this PR adds the tests onto #1632's head.Test plan
uv run pytest tests/cli/test_debug_simulation.py— 18 passed (3 new)uv run pytest(full suite) — 1851 passedruff checkandruff format --checkclean🤖 Generated with Claude Code