📝 Clarified GHOST_PORT comment in .env.example (#80)#218
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe comment block in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Rewrites the GHOST_PORT comment in .env.example so it accurately describes
the variable's behaviour on current main.
Why
Refs #80. After #88 removed the expose entry from the ghost service,
GHOST_PORT no longer affects the port Ghost serves on — it isn't referenced
in compose.yml and server__port is never set. Ghost listens on 2368
internally, caddy/Caddyfile.example proxies to ghost:2368, and the public
port is set via HTTP_PORT / HTTPS_PORT. The only remaining consumer of
GHOST_PORT is scripts/migrate.sh, which prints it in the "forward traffic to
127.0.0.1:" migration message.
The existing comment ("Port Ghost should listen on… host multiple sites on
the same server") is inaccurate and has repeatedly confused users (#80). This
clarifies it and points to HTTP_PORT / HTTPS_PORT. It intentionally keeps the
# GHOST_PORT=2368line, since migrate.sh still reads it. Docs-only; itdoesn't address the separate "configurable internal port" discussion noted in
#88 — happy to adjust scope if you'd prefer it folded into that.
How tested
Verified against current main by grepping the repo (GHOST_PORT, server__port,
2368) and reading compose.yml, caddy/Caddyfile.example, and scripts/migrate.sh.
Docs-only change; no behaviour modified.