Skip to content

chore(bus): prune stale dequeue result type#365

Merged
yordis merged 1 commit into
masterfrom
yordis/chore-prune-queue-batch-result
May 14, 2026
Merged

chore(bus): prune stale dequeue result type#365
yordis merged 1 commit into
masterfrom
yordis/chore-prune-queue-batch-result

Conversation

@yordis

@yordis yordis commented May 14, 2026

Copy link
Copy Markdown
Member
  • The old dequeue result shape no longer has a consumer after queue routing moved to message synchronization groups.
  • Keeping the orphaned type makes the bus surface look broader than it is.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented May 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk cleanup that deletes an unused bus DTO/struct; main risk is only for downstream code that might still reference the type.

Overview
Removes the unused QueueBatchDequeueResult struct (QueueBatchDequeueResult.cs), pruning a stale part of the bus surface that no longer has any in-repo references.

Reviewed by Cursor Bugbot for commit 44dc566. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33f1ebc2-f66d-4536-a4d2-6d00689be7c8

📥 Commits

Reviewing files that changed from the base of the PR and between 5ade564 and 44dc566.

📒 Files selected for processing (1)
  • src/EventStore.Core/Bus/QueueBatchDequeueResult.cs
💤 Files with no reviewable changes (1)
  • src/EventStore.Core/Bus/QueueBatchDequeueResult.cs

Walkthrough

A public struct QueueBatchDequeueResult and its containing file src/EventStore.Core/Bus/QueueBatchDequeueResult.cs were removed from the codebase. The struct included two fields: DequeueCount and EstimateCurrentQueueCount.

Changes

Cohort / File(s) Summary
Type Removal
src/EventStore.Core/Bus/QueueBatchDequeueResult.cs
Removed public struct QueueBatchDequeueResult with DequeueCount and EstimateCurrentQueueCount fields. This type was previously used to convey dequeue result information for ISingleConsumerMessageQueue.TryDequeue.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A struct once held the queue's sweet count,
But now it fades without a doubt,
The dequeue dance must find new ways,
As we hop through cleaner days! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: removal of a stale dequeue result type from the bus module.
Description check ✅ Passed The description provides clear context for why the change was made, explaining that the type became obsolete after architectural changes to queue routing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-prune-queue-batch-result

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis yordis merged commit 8e4a55c into master May 14, 2026
22 checks passed
@yordis yordis deleted the yordis/chore-prune-queue-batch-result branch May 14, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant