Skip to content

adding CheckConstraint to StopPointInJourneyPattern #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ue71603 wants to merge 6 commits into
base: v2.1-wip
Choose a base branch
from
+11 −2
Open

adding CheckConstraint to StopPointInJourneyPattern #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a348d1
adding CheckConstraint to StopPointInJourneyPattern
ue71603 May 6, 2026
a471f2a
Update xsd/netex_part_1/part1_tacticalPlanning/netex_servicePattern_v…
ue71603 May 8, 2026
0f638c5
Update v2.1-wip branch from v2.0 (#1023)
TuThoThai May 8, 2026
6ad6416
Merge branch 'v2.1-wip' into CheckConstraint_added_StopPointInJourney…
TuThoThai May 8, 2026
34348c0
Lint and update documentation tables
github-actions[bot] May 8, 2026
9cd5bab
Merge branch 'v2.1-wip' into CheckConstraint_added_StopPointInJourney…
TuThoThai May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,4 @@ fabric.properties
# Editor-based Rest Client
.idea/httpRequests

/.idea
4 changes: 4 additions & 0 deletions examples/functions/timetable/Netex_01.2_Bus_SimpleTimetable_WithTimings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,10 @@ The Calendar is shown coded as
<Advertised>true</Advertised>
</NoticeAssignment>
</noticeAssignments>
<!-- check for CheckConstraint. V2.1 -->
<CheckConstraint id="mybus:cc:1" version="any">
<Congestion>noWaiting</Congestion>
</CheckConstraint>
</StopPointInJourneyPattern>
<StopPointInJourneyPattern version="any" order="2" id="hde:spijp_24o_02">
<ScheduledStopPointRef version="any" ref="mybus:SSP_002"/>
Expand Down
8 changes: 6 additions & 2 deletions xsd/netex_part_1/part1_tacticalPlanning/netex_servicePattern_version.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@
<!-- ======================================================================= -->
<xsd:include schemaLocation="netex_servicePattern_support.xsd"/>
<xsd:include schemaLocation="../part1_tacticalPlanning/netex_fareZone_support.xsd"/>
<xsd:include schemaLocation="../../netex_part_1/part1_ifopt/netex_ifopt_checkConstraint_version.xsd"/>
<xsd:include schemaLocation="netex_journeyPattern_version.xsd"/>
<xsd:include schemaLocation="netex_timingPattern_version.xsd"/>
<xsd:include schemaLocation="netex_siteConnection_version.xsd"/>
<xsd:include schemaLocation="../part1_networkDescription/netex_flexibleNetwork_version.xsd"/>
<xsd:include schemaLocation="../../netex_part_2/part2_occupancy/netex_oc_occupancy_version.xsd"/>
<xsd:include schemaLocation="../../netex_part_2/part2_journeyTimes/netex_vehicleJourneyStopAssignment_version.xsd"/>
<!-- ======================================================================= -->
<xsd:annotation>
<xsd:appinfo>
Expand Down Expand Up @@ -63,8 +65,7 @@
<Requires>http://www.netex.org.uk/schemas/1.0/PATH/netex_prereqfile.xsd</Requires>
</Relation>
<Rights>Unclassified
<Copyright>CEN, Crown Copyright 2009-2023</Copyright>
</Rights>
<Copyright>CEN, Crown Copyright 2009-2023</Copyright></Rights>
<Source>
<ul>
<li>Derived from the Transmodel, VDV, TransXChange, NEPTUNE, BISON and Trident standards.</li>
Expand Down Expand Up @@ -901,6 +902,9 @@ Rail transport, Roads and Road transport
<xsd:documentation>Nature of use of stop, e.g. access, interchange only, or pass through. Default is Access.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:group ref="QuayAssignmentGroup"/>
Copy link
Copy Markdown
Contributor

@skinkie skinkie May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you place it in the middle to align it with Call?

Copy link
Copy Markdown
Contributor Author

@ue71603 ue71603 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried. But different place would also be ok. We had in OJP some cases where we switched the order of some elements in service and this caused problems. So to do it as harmonised as possible seems a good idea to me.

Copy link
Copy Markdown
Contributor

@skinkie skinkie May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You understand that the way you are now doing it explicitly would break parsing and validation? So if it was deliberate to put them here, was this because in the other structures they are already at this point?

<xsd:element ref="AccessibilityAssessment" minOccurs="0"/>
<xsd:element ref="CheckConstraint" minOccurs="0"/>
<xsd:choice>
<xsd:element name="bookingArrangements" type="bookingArrangements_RelStructure" minOccurs="0">
<xsd:annotation>
Expand Down
Loading