Skip to content

Remove deprecated move_model parameter from ActivationCache.to #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlarson4 merged 1 commit into from
May 29, 2026
Merged

Remove deprecated move_model parameter from ActivationCache.to #1344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions transformer_lens/ActivationCache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class first, including the examples, and then skimming the available methods. Yo
from __future__ import annotations

import logging
import warnings
from typing import (
TYPE_CHECKING,
Any,
Expand Down Expand Up @@ -220,7 +219,7 @@ def __len__(self) -> int:
"""
return len(self.cache_dict)

def to(self, device: Union[str, torch.device], move_model=False) -> ActivationCache:
def to(self, device: Union[str, torch.device]) -> ActivationCache:
"""Move the Cache to a Device.

Mostly useful for moving the cache to the CPU after model computation finishes to save GPU
Expand All @@ -231,23 +230,10 @@ def to(self, device: Union[str, torch.device], move_model=False) -> ActivationCa
Args:
device:
The device to move the cache to (e.g. `torch.device.cpu`).
move_model:
Whether to also move the model to the same device. @deprecated

"""
# Move model is deprecated as we plan on de-coupling the classes
if move_model is not None:
warnings.warn(
"The 'move_model' parameter is deprecated.",
DeprecationWarning,
)

warn_if_mps(device)
self.cache_dict = {key: value.to(device) for key, value in self.cache_dict.items()}

if move_model:
self.model.to(device)

return self

def toggle_autodiff(self, mode: bool = False):
Expand Down
Loading