docs: catalog tests.utils helpers and indexing rules in TESTING.md#511
Open
FelipeDefensor wants to merge 1 commit into
Open
docs: catalog tests.utils helpers and indexing rules in TESTING.md#511FelipeDefensor wants to merge 1 commit into
FelipeDefensor wants to merge 1 commit into
Conversation
Two takeaways from PR #501 review threads: - Add a "Use helpers in tests.utils" section listing the helpers most test files reach for (save_and_reopen, undoable, reloadable, load_local_media, menu/command discovery, modal-dialog patches) so authors find them before re-inventing the same sequences. - Add an "Index timelines and UI elements directly" section: prefer range_tlui[0] over list(range_tlui)[0], and prefer UI-layer access (range_tlui[0].get_data("joined_right")) over reaching into the backend through .timeline / .rows / .components.
azfoo
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two takeaways from PR #501 review threads, surfaced as guidance in
TESTING.md:tests.utilssection — short catalog of the helpers tests most often reach for (save_and_reopen,undoable,reloadable,load_local_media, menu/command discovery, modal-dialog patches). Several PR feat: range timeline #501 threads pointed at copy-pasted save-load sequences that should have beensave_and_reopen(tmp_path); this section makes the helpers discoverable.range_tlui[0]overlist(range_tlui)[0], and prefer UI-layer access (range_tlui[0].get_data("joined_right")) over reaching into the backend.Test plan