feat: persist ids and components order when saving#498
Open
FelipeDefensor wants to merge 2 commits into
Open
Conversation
This was referenced May 3, 2026
FelipeDefensor
force-pushed
the
cleanup/persist-ids
branch
from
0356194 to
ef90488
Compare
Adds tests/timelines/test_serialize.py with serialize-sorting checks, in-memory and on-disk round-trip tests for marker, beat, harmony, pdf, audiowave and score timelines, undo/redo id transmission tests, and broader score coverage (full piece, sorted ids, non-sequential ids, staff_index references).
Collaborator
Author
|
Closes #384 |
azfoo
approved these changes
May 13, 2026
azfoo
left a comment
azfoo
left a comment
Collaborator
There was a problem hiding this comment.
Approving, but I still think there must be a better name to describe what we're testing
| assert set(result.keys()) == {m1.id, m2.id} | ||
|
|
||
|
|
||
| class TestSerializeDeserializeRoundTrip: |
Collaborator
There was a problem hiding this comment.
maybe TestSequentialSerializeDeserialize?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved files now preserve component IDs and ordering, so reloading produces a deterministic structure. This is fundamental for tidy version control of TiLiA files.