fix: close SVG viewer and clear svg_data when score timeline is cleared#481
Draft
FelipeDefensor wants to merge 1 commit into
Draft
fix: close SVG viewer and clear svg_data when score timeline is cleared#481FelipeDefensor wants to merge 1 commit into
FelipeDefensor wants to merge 1 commit into
Conversation
Clears svg_data in the backend so the viewer property does not re-create the dock widget after deletion. Fixes reset_svg() to use get() directly instead of the svg_view property to avoid creating a new viewer if one doesn't exist. Closes #472.
FelipeDefensor
force-pushed
the
fix/472-score-clear-svg-viewer
branch
from
a554a0e to
3854f34
Compare
Collaborator
Author
|
Add tests for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
svg_datain the backendScoreTLComponentManager.clear()so thesvg_viewproperty cannot recreate a viewer with stale SVG data after clearing.reset_svg()to access the existing viewer directly viaget()instead of going through thesvg_viewproperty (which auto-creates a viewer if none exists).Test plan
Closes #472