Media commands#387
Merged
Merged
Conversation
Merged
Collaborator
|
@FelipeDefensor is this ready for review? |
Collaborator
Author
|
No, this is still in progress. |
Collaborator
Author
|
I don't intend to include this in v0.6.0, by the way. |
FelipeDefensor
force-pushed
the
media-commands
branch
from
a6da69c to
2bdf36f
Compare
`on_drag_end` posted `Post.PLAYER_SEEK`, which has no listeners, so
dragging the trough updated only the visual playback lines (via
SLIDER_DRAG) but never moved the underlying media position. As a
result the toolbar time stayed put. Route the seek through
`commands.execute("media.seek", ...)` like the click handler does.
Also revert the unrelated TimelineScene.set_height playback-line tweak
from e40e834: the playback-line "disappearance" reported earlier was
actually this slider bug (the line jumped to MEDIA_CURRENT_TIME, which
never moved), not a height-driven clipping issue.
This was referenced May 3, 2026
Collaborator
Author
|
Range timelines (#501) depend on this. |
azfoo
approved these changes
May 15, 2026
Comment on lines
+196
to
+197
| def on_seek(self, time: float, if_playing: bool = True) -> None: | ||
| if not if_playing and self.is_playing: |
Collaborator
There was a problem hiding this comment.
if_playing -> seek_if_playing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add tests for some of the related behaviour.