fix(flatpak): enable tray registration and harden documentation#49
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Real flatpak-builder --install test run showed the app starting and staying alive but never becoming reachable: no tray icon, no window. Blitztext starts exclusively as a tray icon (blitztext_linux.py setup_tray), and without --talk-name=org.kde.StatusNotifierWatcher the sandboxed Qt/KDE tray backend can't register the StatusNotifierItem (D-Bus ServiceUnknown), leaving no way to open the GUI at all. Verified via busctl that the tray item registers correctly after the fix. Documented root cause and verification in the Flatpak README.
TimInTech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md,README.de.md, and the Flatpak build notes after the successfully built local Flatpak MVP.--talk-name=org.kde.StatusNotifierWatcher.Tray registration fix
Without access to
org.kde.StatusNotifierWatcher, the Flatpak process started and remained alive, but no tray icon or reachable window appeared. Blitztext is tray-oriented, so this made the sandboxed application effectively inaccessible.The manifest now grants only:
No broad session-bus permission was added.
Real verification after rebuild and installation:
Blitztextorg.freedesktop.DBus.Error.ServiceUnknownDocumentation and CI fix
The secret-hygiene workflow rejected literal API-key examples in
README.mdandREADME.de.md. These examples were replaced with generic descriptions.The workflow and
.github/secret-scan-patterns.txtwere not changed or weakened.Verification
python3 -m compileall app testsQT_QPA_PLATFORM=offscreen WHISPER_GUI_TESTS=1 python -m pytest -q494 passedbash -n scripts/install.shbash -n scripts/verify.shgit diff --checkrepository secret scan using
.github/secret-scan-patterns.txtreal
flatpak-builder --user --installbuildreal Flatpak tray and D-Bus smoke test
Scope exclusions
Rollback
After a squash merge: