test(searches): cover null input cases in IterativeBinarySearch#7375
Open
nickzerjeski wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
test(searches): cover null input cases in IterativeBinarySearch#7375nickzerjeski wants to merge 1 commit intoTheAlgorithms:masterfrom
nickzerjeski wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
nickzerjeski
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
There was a problem hiding this comment.
Pull request overview
Adds missing regression coverage for IterativeBinarySearch’s existing null-safety behavior (returning -1 for null array and null key), aligning the unit suite with the implementation’s guard clauses and preventing future regressions.
Changes:
- Added a unit test asserting
find(null, key)returns-1. - Added a unit test asserting
find(array, null)returns-1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7375 +/- ##
============================================
+ Coverage 79.50% 79.51% +0.01%
- Complexity 7142 7144 +2
============================================
Files 796 796
Lines 23368 23368
Branches 4596 4596
============================================
+ Hits 18578 18581 +3
+ Misses 4050 4049 -1
+ Partials 740 738 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add regression tests for null safety behavior in
IterativeBinarySearch.The implementation already guards against
null/empty inputs; this PR adds explicit unit coverage to prevent regressions.Fixes #7330
Changes
testBinarySearchNullArraytestBinarySearchNullKeyValidation
mvn -q -Dtest=IterativeBinarySearchTest test