yosys-slang is now sv-elab in BCR.#10884
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the yosys-slang dependency with sv-elab in MODULE.bazel and updates the plugin path accordingly, alongside updating MODULE.bazel.lock. Feedback suggests marking the new sv-elab dependency with dev_dependency = True to ensure it is not transitively pulled in by downstream consumers.
Signed-off-by: Henner Zeller <h.zeller@acm.org>
f0f9323 to
d7d78fc
Compare
|
It looks like there is a different behavior with the slang 11-based sv-elab; it stumbles in mock-array @oharboe can you make sense of it ? |
|
Looks like the root cause is swallowed... tcl is misconfigured though 17:10:10 Warning: Tcl_Init() call failed - no such file or directory |
|
When compiling locally, I see which is the 1_synt.sdc write thing (but I also run in the RBE environment). But that is supposed to be fixed already, right ? |
|
I think this is unrelated, you can check. The-OpenROAD-Project/OpenROAD-flow-scripts#4333 Done, including lots of yak shaving. Waiting for merge or further yaks to shave. |
seems like a real issue and not flakiness |
|
Probably a garden variety configuration problem. Since the error is swallowed, I am thinking yosys-abc. Maybe better now, but abc segfaults/asserts were swallowed in the past. Claude will use the bazel-orfs _deps flow to iterate on it and create a fix. The _deps.flow is documented in .md files |
|
Ok, handing it to you. You can start with this patch to sv-elab and then see what happens. Setting this to draft. |
|
Chased the mock-array regression down. Short version: mock-array passes Why it only says "Canonicalizing RTL for Element failed"The real diagnostic is being swallowed by yosys verbosity. Running the exact
So with the default How to fish (any "Canonicalizing RTL for X failed" / "Compilation failed" in the slang path): re-run with Durable upstream bug (worth its own fix): a hard error should be emitted regardless of Root causepovik/sv-elab@3774661 ("Retire unknown module support") removes if (driver.options.compilationFlags[ast::CompilationFlags::IgnoreUnknownModules])
engine.issue({diag::NoIgnoreUnknownModules, slang::SourceLocation::NoLocation});i.e.
"SYNTH_SLANG_ARGS": "--ignore-unknown-modules --empty-blackboxes -DELEMENT_COLS={}".format(config["cols"]),FixDrop
Referencebazel-orfs PR #763 (The-OpenROAD-Project/bazel-orfs#763) migrates the from-source EDA stack to BCR |
|
Filed the "errors always suppressed by verbosity" diagnosability bug upstream: povik/sv-elab#364 (root cause + suggested fix). That is separate from the |
|
@hzeller Will you fix the problem here? See above... The error propagation fix in sv-elab is orthogonal + it yosys has always swallowed some errors in the past, it keeps improving. Once you have this merged, I'll update bazel-orfs. |
No description provided.