Skip to content

refactor: re-enable disabled tests due to testhost crash#780

Merged
vbreuss merged 1 commit into
mainfrom
topic/check-if-52579-still-applies
May 12, 2026
Merged

refactor: re-enable disabled tests due to testhost crash#780
vbreuss merged 1 commit into
mainfrom
topic/check-if-52579-still-applies

Conversation

@vbreuss
Copy link
Copy Markdown
Member

@vbreuss vbreuss commented May 12, 2026 •
edited
Loading

This PR re-enables previously disabled high-parameter-count setup tests in Mockolate.Tests, based on the premise that the underlying dotnet test/testhost crash (dotnet/sdk#52579) is resolved with SDK 10.0.201.

Changes:

  • Removed #if DEBUG / #endif guards that prevented several [Fact] tests (17/18 parameters) from compiling/running outside Debug builds.

@vbreuss vbreuss self-assigned this May 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

Test Results

    24 files  ± 0      24 suites  ±0   9m 39s ⏱️ +17s
 4 148 tests + 4   4 146 ✅ + 4  2 💤 ±0  0 ❌ ±0 
26 688 runs  +28  26 684 ✅ +28  4 💤 ±0  0 ❌ ±0 

Results for commit a67f0d0. ± Comparison against base commit 59aa105.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

🚀 Benchmark Results

Details 
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)

AMD EPYC 7763 3.07GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.203

[Host] : .NET 10.0.7 (10.0.7, 10.0.726.21808), X64 RyuJIT x86-64-v3


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
CreateMock Mean Error StdDev Ratio Allocated Alloc Ratio
baseline* 67.77 ns 0.790 ns 0.739 ns 0.99 440 B 1.00
Mockolate 68.33 ns 1.266 ns 1.122 ns 1.00 440 B 1.00
Imposter 299.10 ns 11.922 ns 10.569 ns 4.38 2248 B 5.11
TUnitMocks 37.10 ns 0.752 ns 0.704 ns 0.54 192 B 0.44
Moq 1,406.38 ns 12.835 ns 10.021 ns 20.59 2096 B 4.76
NSubstitute 2,058.45 ns 19.499 ns 18.239 ns 30.13 5048 B 11.47
FakeItEasy 1,958.04 ns 24.765 ns 23.166 ns 28.66 2763 B 6.28
Details 
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)

Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.203

[Host] : .NET 10.0.7 (10.0.7, 10.0.726.21808), X64 RyuJIT x86-64-v4


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
Event Mean Error StdDev Ratio Allocated Alloc Ratio
baseline* 314.0 ns 5.27 ns 4.93 ns 0.90 1.78 KB 1.00
Mockolate 350.6 ns 5.09 ns 4.51 ns 1.00 1.78 KB 1.00
Imposter 1,577.6 ns 37.05 ns 30.93 ns 4.50 8.8 KB 4.94
TUnitMocks 245.1 ns 11.42 ns 10.68 ns 0.70 1.34 KB 0.75
Moq 15,386.6 ns 33.15 ns 29.39 ns 43.90 12.51 KB 7.02
NSubstitute 5,882.2 ns 26.06 ns 24.38 ns 16.78 9.05 KB 5.08
FakeItEasy 190,472.8 ns 1,207.06 ns 1,129.08 ns 543.43 15.26 KB 8.57
Details 
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)

AMD EPYC 9V74 2.87GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.203

[Host] : .NET 10.0.7 (10.0.7, 10.0.726.21808), X64 RyuJIT x86-64-v3


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
Indexer N Mean Error StdDev Ratio Allocated Alloc Ratio
baseline* 1 915.4 ns 10.94 ns 9.70 ns 0.88 3.82 KB 1.00
Mockolate 1 1,035.8 ns 34.27 ns 32.05 ns 1.00 3.82 KB 1.00
Imposter 1 913.2 ns 25.83 ns 22.90 ns 0.88 5.16 KB 1.35
Moq 1 176,473.0 ns 1,793.22 ns 1,677.37 ns 170.52 20.37 KB 5.33
NSubstitute 1 9,051.2 ns 26.65 ns 24.92 ns 8.75 12.84 KB 3.36
FakeItEasy 1 10,534.6 ns 54.39 ns 48.21 ns 10.18 13.63 KB 3.57
baseline* 10 2,432.7 ns 50.74 ns 47.47 ns 0.92 4.88 KB 1.00
Mockolate 10 2,633.9 ns 18.80 ns 17.59 ns 1.00 4.88 KB 1.00
Imposter 10 2,176.3 ns 16.31 ns 15.26 ns 0.83 7.97 KB 1.63
Moq 10 186,462.8 ns 930.56 ns 824.92 ns 70.80 29.89 KB 6.13
NSubstitute 10 21,730.6 ns 58.03 ns 51.44 ns 8.25 25.63 KB 5.26
FakeItEasy 10 22,182.5 ns 75.65 ns 70.76 ns 8.42 32.97 KB 6.76
Details 
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)

Intel Xeon Platinum 8370C CPU 2.80GHz (Max: 3.39GHz), 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.203

[Host] : .NET 10.0.7 (10.0.7, 10.0.726.21808), X64 RyuJIT x86-64-v4


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
Method N Mean Error StdDev Ratio Allocated Alloc Ratio
baseline* 1 365.9 ns 2.90 ns 2.72 ns 0.90 2.04 KB 1.00
Mockolate 1 406.1 ns 13.26 ns 12.40 ns 1.00 2.04 KB 1.00
Imposter 1 584.1 ns 15.93 ns 14.90 ns 1.44 4.04 KB 1.98
TUnitMocks 1 475.6 ns 10.47 ns 9.28 ns 1.17 1.88 KB 0.92
Moq 1 137,237.8 ns 481.74 ns 450.62 ns 338.24 14.59 KB 7.15
NSubstitute 1 6,021.2 ns 31.57 ns 29.53 ns 14.84 9.12 KB 4.47
FakeItEasy 1 5,801.7 ns 76.49 ns 63.87 ns 14.30 8.06 KB 3.95
baseline* 10 636.8 ns 3.37 ns 2.99 ns 0.77 2.25 KB 1.00
Mockolate 10 831.8 ns 7.76 ns 7.25 ns 1.00 2.25 KB 1.00
Imposter 10 1,228.8 ns 35.48 ns 33.19 ns 1.48 5.52 KB 2.45
TUnitMocks 10 1,510.7 ns 8.50 ns 7.95 ns 1.82 3.52 KB 1.57
Moq 10 142,481.3 ns 503.21 ns 470.70 ns 171.31 18.49 KB 8.22
NSubstitute 10 8,814.3 ns 64.43 ns 57.11 ns 10.60 12.07 KB 5.36
FakeItEasy 10 9,393.9 ns 54.57 ns 51.05 ns 11.29 15.42 KB 6.85
Details 
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)

AMD EPYC 9V74 2.87GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.203

[Host] : .NET 10.0.7 (10.0.7, 10.0.726.21808), X64 RyuJIT x86-64-v3


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
Property N Mean Error StdDev Ratio Allocated Alloc Ratio
baseline* 1 516.9 ns 6.22 ns 5.52 ns 0.89 2.47 KB 1.00
Mockolate 1 580.7 ns 15.82 ns 14.80 ns 1.00 2.47 KB 1.00
Imposter 1 459.9 ns 4.17 ns 3.70 ns 0.79 3.13 KB 1.27
TUnitMocks 1 440.4 ns 6.99 ns 6.20 ns 0.76 1.49 KB 0.60
Moq 1 10,721.2 ns 45.23 ns 40.10 ns 18.47 10.27 KB 4.16
NSubstitute 1 7,158.3 ns 47.39 ns 44.33 ns 12.33 11.45 KB 4.64
FakeItEasy 1 7,573.3 ns 45.12 ns 39.99 ns 13.05 11.24 KB 4.55
baseline* 10 1,059.1 ns 16.93 ns 15.84 ns 0.95 2.96 KB 1.00
Mockolate 10 1,120.0 ns 22.04 ns 19.53 ns 1.00 2.96 KB 1.00
Imposter 10 1,119.2 ns 22.66 ns 21.19 ns 1.00 4.67 KB 1.58
TUnitMocks 10 1,499.7 ns 15.88 ns 14.86 ns 1.34 3.65 KB 1.23
Moq 10 17,130.6 ns 43.11 ns 33.66 ns 15.30 17.03 KB 5.75
NSubstitute 10 17,166.0 ns 46.87 ns 43.84 ns 15.33 21.08 KB 7.12
FakeItEasy 10 17,909.2 ns 165.69 ns 146.88 ns 16.00 30.81 KB 10.40
Details 
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)

AMD EPYC 7763 2.59GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.203

[Host] : .NET 10.0.7 (10.0.7, 10.0.726.21808), X64 RyuJIT x86-64-v3


Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10
Callback Mean Error StdDev Ratio Allocated Alloc Ratio
baseline* 313.6 ns 0.95 ns 0.89 ns 0.94 1.68 KB 1.00
Mockolate 334.4 ns 5.13 ns 4.55 ns 1.00 1.68 KB 1.00
Imposter 422.5 ns 9.77 ns 8.16 ns 1.26 2.38 KB 1.42
TUnitMocks 446.5 ns 2.91 ns 2.73 ns 1.34 1.86 KB 1.11
Moq 96,298.4 ns 268.66 ns 238.16 ns 288.06 8.88 KB 5.29
NSubstitute 4,293.6 ns 25.73 ns 24.06 ns 12.84 7.74 KB 4.61
FakeItEasy 4,724.6 ns 21.20 ns 19.83 ns 14.13 6.81 KB 4.05

baseline* rows show the corresponding Mockolate benchmark from the most recent successful main branch build with results, for regression comparison.

@vbreuss vbreuss force-pushed the topic/check-if-52579-still-applies branch from 701c7a3 to a67f0d0 Compare May 12, 2026 16:30
@vbreuss vbreuss marked this pull request as ready for review May 12, 2026 16:31
Copilot AI review requested due to automatic review settings May 12, 2026 16:31
Copilot AI reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables previously disabled high-parameter-count setup tests in Mockolate.Tests, based on the premise that the underlying dotnet test/testhost crash (dotnet/sdk#52579) is resolved with SDK 10.0.201.

Changes:

  • Removed #if DEBUG / #endif guards that prevented several [Fact] tests (17/18 parameters) from compiling/running outside Debug builds.

Comment thread Tests/Mockolate.Tests/MockMethods/SetupMethodTests.cs
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 12, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss merged commit 9567a84 into main May 12, 2026
21 checks passed
@vbreuss vbreuss deleted the topic/check-if-52579-still-applies branch May 12, 2026 18:23
github-actions Bot added a commit that referenced this pull request May 12, 2026
@github-actions
Update benchmark for 9567a84: refactor: re-enable disabled tests due …
3db99af 
…to testhost crash (#780) by Valentin Breuß
github-actions Bot added a commit that referenced this pull request May 12, 2026
@github-actions
Update benchmark for 9567a84: refactor: re-enable disabled tests due …
96b1260 
…to testhost crash (#780) by Valentin Breuß
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@vbreuss vbreuss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss