fix: use current location for canonical URL during SSR#826
Merged
tannerlinsley merged 1 commit intomainfrom Apr 14, 2026
Merged
fix: use current location for canonical URL during SSR#826tannerlinsley merged 1 commit intomainfrom
tannerlinsley merged 1 commit intomainfrom
Conversation
The canonical path selector read from `state.resolvedLocation`, which represents the previously resolved location and is undefined on the initial SSR render. That made every server-rendered page fall back to `/`, so blog posts (and every other route) emitted `<link rel="canonical" href="https://tanstack.com/">`. Mobile share sheets that honor the canonical then shared the root URL instead of the actual post. Switch to `state.location`, which is always populated with the current requested location. https://claude.ai/code/session_01UdssKwjy5SkB6gbB9y6XZS
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The canonical path selector read from
state.resolvedLocation, whichrepresents the previously resolved location and is undefined on the
initial SSR render. That made every server-rendered page fall back to
/, so blog posts (and every other route) emitted<link rel="canonical" href="https://tanstack.com/">. Mobile sharesheets that honor the canonical then shared the root URL instead of the
actual post.
Switch to
state.location, which is always populated with the currentrequested location.
https://claude.ai/code/session_01UdssKwjy5SkB6gbB9y6XZS
Summary by CodeRabbit