Skip to content

test(svelte-query/createMutation): rename 'OnSuccessExample' to 'SuccessExample'#10477

Merged
sukvvon merged 1 commit intomainfrom
test/svelte-query-rename-OnSuccessExample-to-SuccessExample
Apr 13, 2026
Merged

test(svelte-query/createMutation): rename 'OnSuccessExample' to 'SuccessExample'#10477
sukvvon merged 1 commit intomainfrom
test/svelte-query-rename-OnSuccessExample-to-SuccessExample

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 13, 2026

🎯 Changes

  • Rename OnSuccessExample.svelte to SuccessExample.svelte for consistency with FailureExample.svelte

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Updated test suite for the createMutation API to improve test coverage and reliability.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 13, 2026

View your CI Pipeline Execution ↗ for commit 5f2f46a

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 56s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-13 04:31:07 UTC

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 13, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10477

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10477

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10477

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10477

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10477

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10477

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10477

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10477

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10477

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10477

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10477

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10477

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10477

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10477

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10477

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10477

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10477

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10477

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10477

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10477

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10477

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10477

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10477

commit: 5f2f46a

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.99 KB (0%)
react minimal 9.02 KB (0%)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c86dbf31-4776-4085-b39a-2035d63c67f6

📥 Commits

Reviewing files that changed from the base of the PR and between c9109b6 and 5f2f46a.

📒 Files selected for processing (2)
  • packages/svelte-query/tests/createMutation/SuccessExample.svelte
  • packages/svelte-query/tests/createMutation/createMutation.svelte.test.ts

📝 Walkthrough

Walkthrough

A test file's component reference is renamed from OnSuccessExample to SuccessExample in both import and render statements. Props and assertions remain unchanged. This is a test-only modification with no impact on public APIs or functionality.

Changes

Cohort / File(s) Summary
Test Component Reference Update
packages/svelte-query/tests/createMutation/createMutation.svelte.test.ts
Component import and render target renamed from OnSuccessExample to SuccessExample; all test props and assertions unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A component renamed with grace,
From OnSuccess to a simpler place,
The test still passes, assertions hold tight,
Just a refresh to keep things right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: renaming a test component from 'OnSuccessExample' to 'SuccessExample' in the svelte-query createMutation tests.
Description check ✅ Passed The description follows the template structure with all required sections completed: changes are explained with context, both checklist items are checked, and release impact is properly marked as dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/svelte-query-rename-OnSuccessExample-to-SuccessExample

Comment @coderabbitai help to get the list of available commands and usage tips.

@sukvvon sukvvon merged commit aaeefae into main Apr 13, 2026
10 checks passed
@sukvvon sukvvon deleted the test/svelte-query-rename-OnSuccessExample-to-SuccessExample branch April 13, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant