Skip to content

Fixes and improvements#559

Merged
KenVanHoeylandt merged 5 commits into
mainfrom
fixes-and-improvements
Jul 10, 2026
Merged

Fixes and improvements#559
KenVanHoeylandt merged 5 commits into
mainfrom
fixes-and-improvements

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Fixes

    • Added missing Wi-Fi hardware configuration support for P4 devices.
    • Fixed build warning
    • Fixed build wrt Tab5
  • Changes

    • M5Stack StickS3: Switched default storage location from SD to Internal
    • M5Stack StickS3: Removed DIY SD card support over SPI
    • M5Stack StickC Plus2: Removed the automatic startup of the web server

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated two device trees with disabled ESP32 Wi-Fi nodes, removed the StickS3 SPI SD-card configuration, changed device storage and application properties, corrected an RTC service include path, and added a ServiceManifest forward declaration.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too generic and does not describe the actual DTS and configuration changes in the pull request. Rename it to reflect the main change, such as adding Wi-Fi support and device configuration updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes-and-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt KenVanHoeylandt merged commit c4406b2 into main Jul 10, 2026
56 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the fixes-and-improvements branch July 10, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant