Remove the visualization stub and [visualization] extra#30
Merged
Conversation
Mirror MATLAB RAVEN removing its pathway-map / omics-overlay plotting functions (drawMap, colorPathway, drawPathway, markPathwayWith*, setOmicDataToRxns, ...) as obsolete/low-value (SysBioChalmers/RAVEN #618). raven-python only had a not-implemented `visualization` stub reserving that domain; drop it and its scaffolding. cobrapy + Escher cover pathway/omics visualization externally. - Delete src/raven_python/visualization/ and tests/test_visualization.py. - Drop the [visualization] (matplotlib) extra; remove it from CI, ReadTheDocs, and the installation / README / api-index / todo docs. - CHANGELOG: record the removal. The other functions RAVEN removed (MetaCyc, xml_toolbox, Excel-import wrappers, solveQP) were never ported to raven-python, so no further changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors MATLAB RAVEN's removal of obsolete/low-value functions (SysBioChalmers/RAVEN #618) — specifically its pathway-map / omics-overlay plotting functions (
drawMap,drawPathway,colorPathway,markPathwayWithExpression,setOmicDataToRxns, …).raven-python never ported those; it only had a not-implemented
visualizationstub reserving that namespace (a future-Escher roadmap). This drops the stub and its scaffolding so the package no longer advertises a feature the upstream deemed obsolete. cobrapy + Escher cover pathway/omics visualization externally.Removed
src/raven_python/visualization/andtests/test_visualization.py[visualization](matplotlib) optional extraNot affected: the other functions RAVEN removed in that cleanup (MetaCyc,
xml_toolbox, Excel-import wrappers,solveQP) were never ported to raven-python, so no further changes were needed.Verified: 634 tests pass, ruff + mypy clean.