Dedupe the lexer numeric-suffix list

[StreamDemon]

Summary

• Hoists the numeric-suffix table — previously duplicated verbatim in numeric_suffix and validate_numeric_body — into a single shared NUMERIC_SUFFIXES const in sploosh-lexer.
• numeric_suffix now returns the matched &'static str instead of allocating a String per scan.
• Adds a table-driven test that lexes 1<suffix> for every entry in the shared list (kind + lexeme + span asserted), so future suffix additions are covered automatically.

First sub-PR of the parser enhancement wave (targets feature/parser-enhancements-base, see PR #71 roadmap: "Dedupe the numeric-suffix list in the lexer"). No behavior change.

Related Issue

None (PR #71 roadmap item).

Spec Sections Affected

None — implementation quality only.

Checklist

• Code follows the Sploosh design principles (one way to do it, explicit over implicit, etc.)
• Documentation updated in relevant docs/ pages — N/A, no behavior change
• Tests added or updated
• All build targets still compile (if applicable)
• Spec-only PR (skip Build Targets section if checked)

Build Targets Tested

• cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace all green locally (49 tests).

Test Plan

• New every_numeric_suffix_lexes test iterates NUMERIC_SUFFIXES and asserts token kind (IntLit/FloatLit), lexeme, and span for each suffix.
• Existing suffix/separator tests (lexes_suffixed_numbers, rejects_int_suffix_on_float_literals, rejects_float_suffix_on_based_literals, separator_validation_is_base_aware) continue to pass unchanged.

---

Summary by cubic

Deduplicates the lexer numeric-suffix list by moving it into a shared NUMERIC_SUFFIXES const used by both suffix scanning and separator validation, and returns &'static str to avoid per-scan allocation. Adds a table-driven test that lexes 1<suffix> for every entry; behavior is unchanged.

^{Written for commit e31a214. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

Architecture diagram

sequenceDiagram
    participant Lexer as sploosh-lexer Lexer
    participant Suffixes as NUMERIC_SUFFIXES const
    participant Token as Token

    Note over Lexer,Token: Numeric literal lexing (unchanged flow, source of truth deduped)

    Lexer->>Lexer: scan_numeric_literal()
    Lexer->>Suffixes: CHANGED: iterate &NUMERIC_SUFFIXES
    Suffixes-->>Lexer: &'static str suffix match (was String allocation)
    alt Suffix found
        Lexer->>Lexer: advance pos by suffix.len()
        Lexer-->>Token: produce IntLit / FloatLit
    else No suffix
        Lexer-->>Token: produce numeric literal without suffix
    end

    Note over Lexer,Suffixes: Separator validation also uses same const

    Lexer->>Lexer: validate_numeric_body(start, base)
    Lexer->>Suffixes: NEW: strip suffix via &NUMERIC_SUFFIXES
    Suffixes-->>Lexer: body without suffix

    Note over Lexer,Token: Table-driven test covers all suffixes

    participant Test as every_numeric_suffix_lexes test

    Test->>Suffixes: iterate NUMERIC_SUFFIXES
    loop for each suffix
        Test->>Lexer: lex("1{suffix}")
        Lexer-->>Test: tokens[0] (kind, lexeme, span)
        Test->>Test: assert kind (IntLit / FloatLit)
        Test->>Test: assert lexeme == "1{suffix}"
        Test->>Test: assert span correct
    end

Loading

<sub>Auto-approved: Refactors numeric suffix list into shared constant and returns &'static str instead of allocating, with new table-driven tests. No behavior change, low risk.

Re-trigger cubic</sub>