chore: repo setup — CI, license, .gitattributes#3
Merged
Conversation
- CI: GitHub Actions runs `vp check` (format+lint+typecheck) and the test suite on every PR and push to main, via the project's own vite-plus dep (pnpm install + pnpm exec vp) — no separate installer needed. - LICENSE: MIT for the RiftForge software, with an explicit notice that the transcribed Rifts rules content is © Palladium Books and not covered. - README: "License & intellectual property" section documenting the carve-out. - .gitattributes: normalize line endings to LF (stops CRLF churn on Windows). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Addresses Cubic review on PR #3: - run `vp run rules#build` so broken packages are caught in CI, not at release - restrict GITHUB_TOKEN to `contents: read` (least privilege) - pin actions/checkout, actions/setup-node, pnpm/action-setup to commit SHAs instead of mutable major tags (supply-chain hardening) Job name kept as "Check & Test" to match the required status check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the previously-abandoned repo configuration.
Changes
.github/workflows/ci.yml) — runsvp check(format + lint + typecheck) and the 51-test suite on every PR and push tomain. Uses the project's ownvite-plusdependency (pnpm install --frozen-lockfile→pnpm exec vp …), so no separate toolchain install is needed.Also applied to repo settings (out-of-band)
Description, topics, auto-merge, and Dependabot alerts + automated security fixes are enabled. Branch protection on
main(require PR + passing CI) will be enabled once this CI check has run once.Summary by cubic
Set up CI to run
vp run rules#check,rules#test, andrules#buildon every PR and pushes tomainusing the repo’svite-plusviapnpm, with least‑privilegecontents: read, SHA‑pinned actions, and concurrency to cancel in‑progress runs. Added an MIT license for the software with a clear carve‑out for Palladium‑owned rules content, updated the README with the IP notice, and normalized line endings to LF via.gitattributes.Written for commit 414b4f4. Summary will update on new commits.