feat(rules): Rifts rules engine — attributes, dice, LLW O.C.C., combat, skills by StreamDemon · Pull Request #2 · StreamDemon/RiftForge

StreamDemon · 2026-07-01T15:25:54Z

Summary

First vertical slice of the RiftForge rules layer — a smart character builder + live sheet for the Rifts TTRPG (Rifts Ultimate Edition). Establishes the decoupled rules architecture and drives the Ley Line Walker O.C.C. end-to-end.

Architecture (`packages/rules`)

src/content/ — rules as page-stamped JSON, transcribed from the scanned rulebook via vision extraction
src/schema/ — Zod schemas that validate the content at load (a mis-transcribed cell fails fast)
src/engine/ — pure, testable TypeScript deriving every number (no Convex, no UI)

What's included

Attributes (p.281) — Attribute Bonus Chart → derived strike/parry/dodge/save bonuses
Dice — notation parser/roller (3D6*10+20), min/max/average
Ley Line Walker O.C.C. (pp.113–116) — P.P.E. (3D6×10+20 + P.E.), level-gated bonuses, abilities, skill grants, money
Combat/HP (pp.287, 346–347) — Hit Points, S.D.C., attacks-per-melee, Hand-to-Hand tables, saving-throw targets; combatProfile()
Skills (pp.299, 304–330) — resolveSkill(): base% + O.C.C./I.Q./per-level bonuses, 98% cap; the LLW's full skill list resolves

Verification

vp run rules#test → 44 tests pass
vp run rules#check → format + lint + typecheck clean

Notes

The 59 MB source PDF (© Palladium Books) is git-ignored; docs/rules/PAGE_MAP.md indexes it.
Follow-ups: magic subsystem + spells; Hand-to-Hand Expert/MA/Assassin; Convex backend wiring.

Baseline created via `vp create vite:monorepo` (pnpm workspace + root Vite+ config). Demo apps/packages removed; the rules package lands next. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw

…t, skills First vertical slice of the RiftForge rules layer, transcribed from Rifts Ultimate Edition (scanned PDF -> vision extraction). Decoupled content (page-stamped JSON) / schema (Zod) / engine (pure TS). - Attribute Bonus Chart (p.281) -> derived combat/save bonuses - Dice notation parser/roller (3D6*10+20 etc.) - Ley Line Walker O.C.C. (pp.113-116): P.P.E., bonuses, abilities, skills, money - Combat/HP: Hit Points, S.D.C., attacks/melee, Hand-to-Hand tables, saving throws - Skill system: base% + O.C.C./I.Q./per-level, 98% cap; LLW skill list resolves 44 tests pass; `vp check` (format + lint + typecheck) clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw

StreamDemon · 2026-07-01T15:31:43Z

@cubic-dev-ai Please review this PR.

cubic-dev-ai · 2026-07-01T15:31:59Z

@cubic-dev-ai Please review this PR.

@StreamDemon I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

22 issues found across 33 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

Resolves all 22 findings from the Cubic review on PR #2. Validation hardening (reject bad transcriptions at load): - skills: baseSkill/baseSkill2/perLevel >= 0, maxPercent > 0 - combat: H2H level > 0; attack/action counts >= 0; type id/name non-empty; saveTarget must have exactly one of target/targetRange - occ: P.P.E. recovery & supplemental values >= 0 - shared diceFormulaSchema — dice-string fields now validated at load, not at parse Correctness / consistency: - combat: hitPointsRange() honors perLevelStartsAt (was hardcoded to level 2) - combat: unknown Hand-to-Hand id now throws instead of silently returning 1 attack - LLW grants carry skillId/hthId + skillPrefix so they resolve by id, not fragile name matching; "Communications" category normalized to "Communication" Housekeeping: - remove broken root `dev` script (no website package) - README describes RiftForge, not the generic Vite+ starter - catalog @types/node ^24 -> ^22 to match engines >=22.18.0 - test the previously-unasserted poison save bonus 45 tests pass; `vp check` clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw

These were removed on main; a line-ending re-normalization accidentally re-touched them here, causing a modify/delete conflict. Remove them so the branch agrees with main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw

StreamDemon · 2026-07-01T16:02:11Z

Addressed all 22 Cubic findings ✅ (commit `868e805`)

Validated each — all were legitimate. Grouped fixes:

Schema validation hardening (reject bad transcriptions at load, not at parse):

skills: baseSkill/baseSkill2/perLevel ≥ 0, maxPercent > 0
combat: H2H level > 0, action-count fields ≥ 0, type id/name non-empty; saveTarget must have exactly one of target/targetRange
occ: P.P.E. recovery* and supplemental* ≥ 0
New shared diceFormulaSchema — all dice-string fields now validated (a malformed "3D6x" fails at load)

Correctness / consistency:

hitPointsRange() now honors perLevelStartsAt (was hardcoded to level 2) — matches rollHitPoints()
Unknown Hand-to-Hand id now throws instead of silently returning 1 attack
LLW grants carry skillId/hthId + skillPrefix so they resolve by id, not fragile name matching; "Communications" → "Communication"

Housekeeping:

removed broken root dev script (no website package)
README now describes RiftForge, not the Vite+ starter
catalog @types/node ^24 → ^22 to match engines >=22.18.0
added the missing saveBonuses.poison assertion

45 tests pass; vp check (format + lint + typecheck) clean.

cubic-dev-ai

1 issue found across 13 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

…e aliases - combat: saveTargetSchema now rejects an inverted targetRange (min > max) - skills: add `aliases` to the catalog + `getSkillByName()` name resolver, so O.C.C. grants that use a book's alternate wording (e.g. "Lore: Demon & Monster", "Math: Basic") resolve to the catalog by name as well as by id. 48 tests pass; `vp check` clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw

cubic-dev-ai

1 issue found across 6 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Cubic flagged that the name index silently overwrote colliding normalized keys, which could drop a skill from name-resolution unnoticed. Extract buildSkillIndexes(): it throws on a duplicate id or on a name/alias that normalizes to a key already owned by a different skill, instead of shadowing it. Tests cover both collision cases and confirm the real catalog is clean. 51 tests pass; `vp check` clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ur5Eu6dC17feVQH5smrFw

StreamDemon and others added 2 commits July 1, 2026 23:22

cubic-dev-ai Bot reviewed Jul 1, 2026

View reviewed changes

StreamDemon and others added 2 commits July 1, 2026 23:59

cubic-dev-ai Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/rules/src/schema/combat.ts

cubic-dev-ai Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/rules/src/engine/skills.ts Outdated

StreamDemon merged commit 8964e91 into main Jul 1, 2026
1 check passed

StreamDemon deleted the feat/rules-engine-llw-slice branch July 1, 2026 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rules): Rifts rules engine — attributes, dice, LLW O.C.C., combat, skills#2

feat(rules): Rifts rules engine — attributes, dice, LLW O.C.C., combat, skills#2
StreamDemon merged 6 commits into
mainfrom
feat/rules-engine-llw-slice

StreamDemon commented Jul 1, 2026 •

edited

Loading

Uh oh!

StreamDemon commented Jul 1, 2026

Uh oh!

cubic-dev-ai Bot commented Jul 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StreamDemon commented Jul 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

StreamDemon commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Architecture (packages/rules)

What's included

Verification

Notes

Uh oh!

StreamDemon commented Jul 1, 2026

Uh oh!

cubic-dev-ai Bot commented Jul 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StreamDemon commented Jul 1, 2026

Addressed all 22 Cubic findings ✅ (commit 868e805)

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

StreamDemon commented Jul 1, 2026 •

edited

Loading

Architecture (`packages/rules`)

cubic-dev-ai Bot left a comment •

edited

Loading

Addressed all 22 Cubic findings ✅ (commit `868e805`)

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading