Skip to content

✨Edit version regex to allow +rke2r\d+ in version string#204

Open
schmidax wants to merge 2 commits intoSovereignCloudStack:mainfrom
schmidax:rke2
Open

✨Edit version regex to allow +rke2r\d+ in version string#204
schmidax wants to merge 2 commits intoSovereignCloudStack:mainfrom
schmidax:rke2

Conversation

@schmidax
Copy link
Copy Markdown

What this PR does / why we need it:
This PR adds another regex for version validation so that cluster-stacks can also be created for rke2 clusters.

@cluster-stack-bot cluster-stack-bot Bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/code Changes made in the code directory labels Dec 19, 2025
@cluster-stack-bot cluster-stack-bot Bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/github Changes made in the github directory and removed size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. labels Dec 19, 2025
@cluster-stack-bot cluster-stack-bot Bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-200 lines, ignoring generated files. labels Dec 19, 2025
Signed-off-by: Axel Schmidt <axel.schmidt@rz.uni-augsburg.de>
Copy link
Copy Markdown
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments:

  • I wonder whether we should allow such suffixes more generally.
    ^v\d+\.\d+\.\d+$|^v\d+\.\d+\.\d+\+[a-zA-Z0-9]+$
  • Does this need corresponding changes elsewhere (CSO) as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/code Changes made in the code directory area/github Changes made in the github directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants