Skip to content

Test driver/no subscriptions #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hcarter-775 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

Test driver/no subscriptions #2992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
934dd80
Merge pull request #2987 from SmartThingsCommunity/main
ctowns May 20, 2026
fe05fa2
do not attempt subscriptions
hcarter-775 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions drivers/SmartThings/matter-switch/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function SwitchLifecycleHandlers.do_configure(driver, device)
device_cfg.match_child_profile(driver, device)
-- because get_parent_device() may cause race conditions if used in init, an initial child subscribe is handled in doConfigure.
-- all future calls to subscribe will be handled by the parent device in init
device:subscribe()
-- device:subscribe()
end
end

Expand All @@ -67,12 +67,12 @@ end
function SwitchLifecycleHandlers.info_changed(driver, device, event, args)
if not switch_utils.deep_equals(device.profile, args.old_st_store.profile, { ignore_functions = true }) then
if device.network_type == device_lib.NETWORK_TYPE_MATTER then
device:subscribe()
-- device:subscribe()
button_cfg.configure_buttons(device,
device:get_endpoints(clusters.Switch.ID, {feature_bitmap=clusters.Switch.types.SwitchFeature.MOMENTARY_SWITCH})
)
elseif device.network_type == device_lib.NETWORK_TYPE_CHILD then
device:get_parent_device():subscribe() -- parent device required to send subscription requests
-- device:get_parent_device():subscribe() -- parent device required to send subscription requests
end
end

Expand Down Expand Up @@ -108,7 +108,7 @@ function SwitchLifecycleHandlers.device_init(driver, device)
end
switch_utils.handle_electrical_sensor_info(device)
device:extend_device("subscribe", switch_utils.subscribe)
device:subscribe()
-- device:subscribe()
end
end

Expand Down
4 changes: 2 additions & 2 deletions drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ end
function IkeaScrollLifecycleHandlers.device_init(driver, device)
device:set_endpoint_to_component_fn(switch_utils.endpoint_to_component)
device:extend_device("subscribe", scroll_utils.subscribe)
device:subscribe()
-- device:subscribe()
end

function IkeaScrollLifecycleHandlers.do_configure(driver, device)
Expand All @@ -31,7 +31,7 @@ end
function IkeaScrollLifecycleHandlers.info_changed(driver, device, event, args)
if device.profile.id ~= args.old_st_store.profile.id then
scroll_cfg.configure_buttons(device)
device:subscribe()
-- device:subscribe()
end
end

Expand Down
Loading