Add BITUO TECHNIK OEM devices for the Zemismart manufacturer#2986
Open
script0803 wants to merge 2 commits into
Open
Add BITUO TECHNIK OEM devices for the Zemismart manufacturer#2986script0803 wants to merge 2 commits into
script0803 wants to merge 2 commits into
Conversation
|
Invitation URL: |
Test Results 72 files 514 suites 0s ⏱️ Results for commit b462de7. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against b462de7 |
cjswedes
reviewed
May 22, 2026
Contributor
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
LGTM, just a few formatting changes needed
Contributor
There was a problem hiding this comment.
Please add the copywrite header to the new test files
| end | ||
| ) | ||
|
|
||
| test.run_registered_tests() No newline at end of file |
Contributor
There was a problem hiding this comment.
nit: please have a trailing newline at the end of each of the test files
Comment on lines
+93
to
+108
| test.register_message_test( | ||
| "ActivePower Report should be handled. Sensor value is in W, capability attribute value is in hectowatts", | ||
| { | ||
| { | ||
| channel = "zigbee", | ||
| direction = "receive", | ||
| message = { mock_device.id, ElectricalMeasurement.attributes.ActivePower:build_test_attr_report(mock_device, | ||
| 27) }, | ||
| }, | ||
| { | ||
| channel = "capability", | ||
| direction = "send", | ||
| message = mock_device:generate_test_message("PhaseA", capabilities.powerMeter.power({ value = 27.0, unit = "W" })) | ||
| } | ||
| } | ||
| ) |
Contributor
There was a problem hiding this comment.
Identical test can be removed.
Suggested change
| test.register_message_test( | |
| "ActivePower Report should be handled. Sensor value is in W, capability attribute value is in hectowatts", | |
| { | |
| { | |
| channel = "zigbee", | |
| direction = "receive", | |
| message = { mock_device.id, ElectricalMeasurement.attributes.ActivePower:build_test_attr_report(mock_device, | |
| 27) }, | |
| }, | |
| { | |
| channel = "capability", | |
| direction = "send", | |
| message = mock_device:generate_test_message("PhaseA", capabilities.powerMeter.power({ value = 27.0, unit = "W" })) | |
| } | |
| } | |
| ) |
| end | ||
| end | ||
| if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") then | ||
| if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true)then |
Contributor
There was a problem hiding this comment.
Suggested change
| if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true)then | |
| if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true) then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Add BITUO TECHNIK OEM devices for the Zemismart manufacturer.
Summary of Completed Tests
test_zigbee_power_meter_1p_ZM
test_zigbee_power_meter_2p_ZM
test_zigbee_power_meter_3p_ZM