[2.1] Don't log guests if disallowed

[sbulen]

Partial for #9136
Fixes #7453

Do any guest logging AFTER checking if guests should be kicked...

This will relieve I/O during bot attacks - no need to log folks who aren't doing anything.

Also, the logging was confusing - it made it look like they were doing something in Who's Online.

[sbulen]

Note that the 'User has been taken to the login page' functionality didn't work in 2.1... Worked OK in 3.0.

It may have been less confusing to users if it were displayed properly in 2.1... Maybe not... In 3.0 it said, "User is viewing board 1.0" (or whatever action) with an icon, which, when the icon was clicked, provided a popup that said "User has been taken to the login page". Contradictory info, and the real state was dependent on folks thinking of clicking on that tiny icon.

[live627]

This looks like it might stop logging for valid topic and board requests.

[sbulen]

This looks like it might stop logging for valid topic and board requests.

All this did was move the logging to AFTER the kickGuest test. What it does today is log invalid requests. This is very confusing, comes up in the support boards regularly. Folks deny guest access, and during a bot attack, Who's Online shows hundreds of guests/bots browsing the forum & doing various actions. When they aren't...

So it's the other way around - today it logs invalid requests, and this change stops that. The log will make more sense.

[live627]

That function has a very weird design where it returns a function name. The problem is that the complex branching logic includes topics.

3.0 thankfully unravels it somewhat...

[jdarwood007]

I think this looks good after we resolve the conversation about moving that array definition.

[sbulen]

OK, array & hook both restored to where they were.

I think this one is ready now.