[3.0] Theme#7933
Conversation
| echo User::$me->avatar['image']; | ||
|
|
||
| echo '<span class="textmenu">', User::$me->name, '</span></a> | ||
| echo '</a> |
There was a problem hiding this comment.
If we do this for the avatar image, shouldn't we use a alt text for the name?
There was a problem hiding this comment.
Should use href or url then.
Or should 'image' provide it by default? It would be good in case an external avatar is missing in other parts of the forum.
There was a problem hiding this comment.
I think either is valid. I believe it just needs something to be valid for screen readers. Since its a link to the users profile and we removed the name, the alt should have it.
There was a problem hiding this comment.
Then I think 'image' should provide the alt text by default. An external avatar could suddenly not load or disappear, would be good to have it.
live627
force-pushed
the
theme
branch
4 times, most recently
from
b7c6385 to
3a78afe
Compare
|
I notice that a few forms would disable textareas on submit, such as the posting form. I've changed this to do all forms by using the new HTML property to make the entire form inert. |
live627
force-pushed
the
theme
branch
2 times, most recently
from
3ba4ff5 to
c823a49
Compare
|
Icons in the admin area are not indented enough: Unable to load the '' template at Forum Maintenance - Routine: SCEditor doesn't have a dark theme? Instead of "X Posts" and "Y Topics", maybe it would still be better to keep "Posts: X" and "Topics: Y" as it is now? |
I’m working on this
Can be fixed later too, but also requires some tweaks.
I don’t have a preference, we might discuss it later for sure. |
live627
force-pushed
the
theme
branch
2 times, most recently
from
2322f68 to
ada494b
Compare
|
@live627 Can you rebase this or merge and fix conflicts? |
|
We have this pending Will start sending more in upcoming weeks, but it could be merged, rest of changes are more focused so can be in separated PR's |
|
Once I can get around to testing and merging that, I'll rebase this branch again |
| <div class="windowbg form_grid"> | ||
| <p class="descbox">', Lang::$txt['authentication_options'], ':</p> | ||
| <p> | ||
| <input type="radio" name="reminder_type" id="reminder_type_email" value="email" checkeiv></label> |
| <input type="submit" value="', Lang::$txt['save'], '" name="save_reserved_names" tabindex="', Utils::$context['tabindex']++, '" class="button"> | ||
| <div class="form_grid"> | ||
| <div> | ||
| <label for="matchword">', Lang::$txt['admin_match_whole'], '</div> |
There was a problem hiding this comment.
<label>...</div> => <label>...</label>?
|
@jdarwood007 I moved some of the login javascript to its own file but don't know how to test cors requests. |
|
When this is closer to ready I can check it. You need to run 2 domains (or 2 subdomains) and have the forum on one and the script on another. A simple SSI page where you can open the user area popup is good enough for most things. Sending credentials such as on the login form may also need to be tested, but when you can open the user area, the CORS request works. |
# Conflicts: # Sources/Actions/Admin/Themes.php
# Conflicts: # Themes/default/Admin.template.php # Themes/default/BoardIndex.template.php # Themes/default/Calendar.template.php # Themes/default/Display.template.php # Themes/default/Errors.template.php # Themes/default/GenericControls.template.php # Themes/default/GenericMenu.template.php # Themes/default/Login.template.php # Themes/default/ManageMaintenance.template.php # Themes/default/ManagePaid.template.php # Themes/default/MessageIndex.template.php # Themes/default/ModerationCenter.template.php # Themes/default/PersonalMessage.template.php # Themes/default/Poll.template.php # Themes/default/Post.template.php # Themes/default/Profile.template.php # Themes/default/Register.template.php # Themes/default/Reports.template.php # Themes/default/Search.template.php # Themes/default/Themes.template.php # Themes/default/index.template.php
|
@sbulen My goal here was to get 7933 into smaller pieces so it can become mergeable. It still is a monster of a commit and includes various features and other changes that could be isolated out. I pulled out so far what I see as pieces that need to come out. We could merge your changes into 7933 and resolve all conflicts if it's better equipped now. Getting Variants and color modes working needs to be done, though. Variants for helping themes be able to apply simple color changes. Color modes for things like dark mode and high contrast as well, which is a modern thing that sites have. |
|
No problem. See further discussion over at https://www.simplemachines.org/community/index.php?msg=4198431 |
Fix popup not allowing tabs
# Conflicts: # Themes/default/Search.template.php
Last edit should be italics Editor should not arbitrarily force a 2 row, let css handle it naturally Expand/collapse comments generated a error Various fixes to get jumpto functional
# Conflicts: # Themes/default/Search.template.php
9 participants
This is the new theme started by @TwitchisMental
I still need to convert several form grids to use CSS grids instead of floats. Also the grids abuse definition list markup, something tat has always annoyed me from the very beginning.
Submitting as a draft now to get early feedback.